Review main Merged

70957[BUGFIX] Streamline DatabaseRecordList usages

Oli Bartsch CR +2 V +2 Normal +43 −8 updated 09/09/21, 10:17

Commit message

DatabaseRecordList is used at various places, e.g.
in the Record Selector, but also for the TableList
view helper. Recently, a lot of patches touched
DatabaseRecordList, leading to some problems for
the usages.

Therefore this patch does the following:

* Include required language file in TableListViewHelper
* Handle "readOnly" setting correctly in TableListViewHelper
* Remove record download action in DatabaseBrowser
* Replace call to non-existing method in RecordDownloadController
* Add missing JavaScript modules for RecordLinkHandler
* Restore "showLimit" property in DatabaseRecordList

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 811

  1. Oli Bartsch uploaded patch set 1 09/07/21, 16:27

  2. Oli Bartsch updated the commit message in patch set 2 09/07/21, 16:32

  3. core-ci voted on patch set 1 V +1 09/07/21, 16:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16381

  4. core-ci voted on patch set 2 V +1 09/07/21, 16:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16382

  5. Benni Mack voted on patch set 2 V +1 CR +1 09/07/21, 18:49

  6. Jochen Roth uploaded patch set 3 09/09/21, 09:43

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 09/09/21, 09:44

  8. Jochen Roth voted on patch set 3 V +1 CR +1 09/09/21, 09:44

  9. core-ci voted on patch set 3 V +1 09/09/21, 09:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16441

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 09/09/21, 10:17

  11. Oli Bartsch merged patch set 4 09/09/21, 10:17