Review main Merged

70960[TASK] runTests.sh: Allow PHP version 8.1

Stefan Bürk CR +2 V +2 Easy +3 −2 updated 09/07/21, 20:47

Commit message

PHP 8.1 introduces language features and deprecations.

As always, the first step is having a green test suite.
Testing container typo3/core-testing-php81 has just
been released, coming with PHP 8.1.0 RC1.

Some issues are obvious when running the test suites,
they will be fixed with upcoming patches. This patch
adds support for PHP 8.1 to runTests.sh, example:

  Build/Scripts/runTests.sh -p 8.1 -s unit

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • crell +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • crell +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Stefan Bürk uploaded patch set 1 09/07/21, 19:26

  2. Stefan Bürk rebased onto patch set 2 09/07/21, 19:26

  3. Stefan Bürk commented on patch set 2 CR -1 09/07/21, 19:27

    Blocked, as it needs released core-testing-php81 docker image first.
  4. core-ci voted on patch set 1 V +1 09/07/21, 19:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16387

  5. core-ci voted on patch set 2 V +1 09/07/21, 19:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16388

  6. Christian Kuhn uploaded patch set 3 09/07/21, 20:32

  7. crell voted on patch set 3 CR +1 09/07/21, 20:37

  8. core-ci voted on patch set 3 V +1 09/07/21, 20:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16396

  9. crell commented on patch set 3 V +1 09/07/21, 20:46

    I just ran this branch locally, and it downloaded the new container, ran unit tests, and shows a whole crapload of fails. Which is exactly what I expected, which means this passes. 😊
  10. Christian Kuhn voted on patch set 3 V +2 CR +2 09/07/21, 20:47

  11. Christian Kuhn merged patch set 4 09/07/21, 20:47