Review main Merged

70965[TASK] Deprecate TSFE->ATagParams

Benni Mack CR +2 V +2 Normal +89 −11 updated 09/16/21, 10:32

Commit message

The TypoScriptFrontendController holds a property
called "ATagParams". Its value is a copy of
$TSFE->config[config][ATagParams].

The information can be retrieved from the config array, just like
all other things are loaded there, as the usages of this property
are rather low.

In addition cObj->getTagParams' 2nd argument "addGlobal"
which is always set to true, is marked as deprecated as well.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1318

  1. Benni Mack uploaded patch set 1 09/08/21, 06:29

  2. core-ci voted on patch set 1 V +1 09/08/21, 06:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16405

  3. Benni Mack uploaded patch set 2 09/16/21, 06:59

  4. core-ci voted on patch set 2 V +1 09/16/21, 07:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16777

  5. Benni Mack uploaded patch set 3 09/16/21, 08:49

  6. core-ci voted on patch set 3 V +1 09/16/21, 09:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16781

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 09/16/21, 10:05

  8. Oli Bartsch voted on patch set 3 V 0 CR 0 09/16/21, 10:06

  9. Oli Bartsch commented on patch set 3 CR -1 09/16/21, 10:12

    Will fix a detail
  10. Oli Bartsch uploaded patch set 4 09/16/21, 10:14

  11. Oli Bartsch uploaded patch set 5 09/16/21, 10:16

  12. core-ci voted on patch set 4 V +1 09/16/21, 10:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16788

  13. core-ci voted on patch set 5 V +1 09/16/21, 10:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16789

  14. Oli Bartsch voted on patch set 5 V +1 CR +1 09/16/21, 10:31

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 09/16/21, 10:31

  16. Jochen Roth voted on patch set 5 V +1 CR +1 09/16/21, 10:32

  17. Oli Bartsch voted on patch set 5 V +2 CR +2 09/16/21, 10:32

  18. Oli Bartsch merged patch set 6 09/16/21, 10:32