Review main Merged

70968[TASK] Replace inline JavaScript in AbstractPlugin

Oliver Hader CR +2 V +2 Normal +59 −12 updated 09/17/21, 15:52

Commit message

Remaining individual inline JavaScript in `onclick` handler to open
an URI in a new window is replaced with default frontend JavaScript
(see #95041) in `AbstractPlugin::pi_openAtagHrefInJSwindow()`.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Oliver Hader uploaded patch set 1 09/08/21, 13:35

  2. Oliver Hader wrote 09/08/21, 13:37

    Topic set to inline-javascript
  3. core-ci voted on patch set 1 V +1 09/08/21, 13:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16411

  4. Oliver Hader uploaded patch set 2 09/17/21, 13:31

  5. core-ci voted on patch set 2 V +1 09/17/21, 13:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16879

  6. Markus Klein voted on patch set 2 CR +1 09/17/21, 15:23

  7. Benni Mack voted on patch set 2 V +1 CR +1 09/17/21, 15:31

  8. Benjamin Franzke commented on patch set 2 CR -1 09/17/21, 15:41

    AbstractPlugin.php:501

    htmlspecialchars?
  9. Benjamin Franzke commented on patch set 2 CR 0 09/17/21, 15:42

    AbstractPlugin.php:501 Reply

    Sorry, misread this format string.
  10. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/17/21, 15:51

  11. Benjamin Franzke merged patch set 3 09/17/21, 15:52