Review main Merged

70969[BUGFIX] Add special case for tables in panels

Oli Bartsch CR +2 V +2 Easy +5 −3 updated 09/08/21, 15:51

Commit message

Using tables in panels requires the tables
to avoid any margin-bottom, since the panel
already defines such.

A special case is using the wrapper class
"table-responsive", placed between the
panel and the table element. This use case
was previously handled by bootstrap directly,
but got removed with v5. We therefore, handle
this case now on our own.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jorgen van der Kroon +1
    • Dennis Prinse +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jorgen van der Kroon +1
    • Dennis Prinse +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 09/08/21, 13:38

  2. core-ci voted on patch set 1 V +1 09/08/21, 13:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16412

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/08/21, 14:31

  4. Jorgen van der Kroon voted on patch set 1 V +1 CR +1 09/08/21, 14:46

  5. Dennis Prinse voted on patch set 1 V +1 CR +1 09/08/21, 14:48

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 09/08/21, 15:50

  7. Oli Bartsch merged patch set 2 09/08/21, 15:51