Review main Merged

70970[TASK] Improve PHPDoc of ResourceStorage::sanitizeFileName

Stephan Großberndt CR +2 V +2 Easy +3 −5 updated 10/12/21, 11:24

Commit message

Adapt description and remove hints on exceptions which are not thrown here.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Stephan Großberndt uploaded patch set 1 09/08/21, 14:38

  2. Stephan Großberndt commented on patch set 1 09/08/21, 14:39

    TYPO3\CMS\Core\Resource\ResourceStorage::sanitizeFileName lists two exceptions which are never thrown: https://gitlab.typo3.org/typo3/typo3/-/blob/master/typo3/sysext/core/Classes/Resource/ResourceStorage.php#L1214 DriverInterface does not mention any exceptions to be expected: https://gitlab.typo3.org/typo3/typo3/-/blob/master/typo3/sysext/core/Classes/Resource/Driver/DriverInterface.php#L87 LocalDriver throws a InvalidFileNameException which is neither mentioned in ResourceStorage nor DriverInterface https://gitlab.typo3.org/typo3/typo3/-/blob/master/typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php#L315 1. Should ResourceStorage contain the hint for the InvalidFileNameException from LocalDriver? 2. Should DriverInterface contain the hint for the InvalidFileNameException from LocalDriver?
  3. core-ci voted on patch set 1 V +1 09/08/21, 14:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16413

  4. Benni Mack commented on patch set 1 10/08/21, 08:26

    Reply

    1. no 2. no
  5. Oliver Klee voted on patch set 1 CR +1 10/08/21, 09:15

  6. Oli Bartsch commented on patch set 1 10/08/21, 16:25

    ResourceStorage.php:1212

    Isn't this wrong too? As far as I can see, no file is added to this folder.
  7. Stephan Großberndt uploaded patch set 2 10/11/21, 10:18

  8. Oliver Klee voted on patch set 2 CR +1 10/11/21, 10:30

  9. core-ci voted on patch set 2 V +1 10/11/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17907

  10. Wouter Wolters voted on patch set 2 CR +1 10/11/21, 17:25

  11. Christian Kuhn voted on patch set 2 V +1 CR +1 10/12/21, 09:57

  12. Benni Mack commented on patch set 2 V +2 CR +2 10/12/21, 10:32

    Reply

    Ack
  13. Benni Mack merged patch set 3 10/12/21, 10:32

  14. Benni Mack commented on patch set 3 10/12/21, 11:24

    ResourceStorage.php:1212 Reply

    Done