70971[TASK] Test if status codes are selectable and send in redirects
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Tests/Acceptance/Application/Redirect/RedirectModuleCest.php+26 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/Redirects.typoscriptnew+13 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectToPages.xmlnew+51 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+53 −0
Review log 1017
-
Richard Haeser uploaded patch set 1 09/08/21, 14:55
-
Richard Haeser updated the commit message in patch set 2 09/08/21, 14:57
-
core-ci voted on patch set 1 V -1 09/08/21, 15:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16414
-
core-ci voted on patch set 2 V -1 09/08/21, 15:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16415
-
Richard Haeser uploaded patch set 3 09/08/21, 19:00
-
core-ci voted on patch set 3 V +1 09/08/21, 19:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16425
-
Stefan Bürk uploaded patch set 4 09/11/21, 13:37
-
core-ci voted on patch set 4 V +1 09/11/21, 13:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16559
-
Stefan Bürk updated the commit message in patch set 5 09/11/21, 14:06
-
Stefan Bürk updated the commit message in patch set 6 09/11/21, 14:07
-
core-ci voted on patch set 5 V +1 09/11/21, 14:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16562
-
core-ci voted on patch set 6 V +1 09/11/21, 14:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16563
-
Stefan Bürk updated the commit message in patch set 7 09/11/21, 14:37
-
Stefan Bürk commented on patch set 7 V +1 CR +1 09/11/21, 14:49
I have tested locally. I have already manuall backported it locally to 10.4 and run functional/accepance tests three, also passes so far. Besides this, I'm not so much into acceptenance tests and cannot say if there may be issues with it, or if it is likely to be flaky. All local runs passed, so I give +1 as verified. -
core-ci voted on patch set 7 V +1 09/11/21, 14:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16566
-
Christian Kuhn voted on patch set 7 V +2 CR +2 09/11/21, 15:50
-
Christian Kuhn merged patch set 8 09/11/21, 15:50