Review main Merged

70971[TASK] Test if status codes are selectable and send in redirects

Richard Haeser CR +2 V +2 Normal +143 −0 updated 09/11/21, 15:50

Commit message

Check if the right status code is added to the header of a redirect.
Furhtermore check if the current available status codes can be selected
when creating a new redirect in the backend.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1017

  1. Richard Haeser uploaded patch set 1 09/08/21, 14:55

  2. Richard Haeser updated the commit message in patch set 2 09/08/21, 14:57

  3. core-ci voted on patch set 1 V -1 09/08/21, 15:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16414

  4. core-ci voted on patch set 2 V -1 09/08/21, 15:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16415

  5. Richard Haeser uploaded patch set 3 09/08/21, 19:00

  6. core-ci voted on patch set 3 V +1 09/08/21, 19:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16425

  7. Stefan Bürk uploaded patch set 4 09/11/21, 13:37

  8. core-ci voted on patch set 4 V +1 09/11/21, 13:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16559

  9. Stefan Bürk updated the commit message in patch set 5 09/11/21, 14:06

  10. Stefan Bürk updated the commit message in patch set 6 09/11/21, 14:07

  11. core-ci voted on patch set 5 V +1 09/11/21, 14:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16562

  12. core-ci voted on patch set 6 V +1 09/11/21, 14:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16563

  13. Stefan Bürk updated the commit message in patch set 7 09/11/21, 14:37

  14. Stefan Bürk commented on patch set 7 V +1 CR +1 09/11/21, 14:49

    I have tested locally. I have already manuall backported it locally to 10.4 and run functional/accepance tests three, also passes so far. Besides this, I'm not so much into acceptenance tests and cannot say if there may be issues with it, or if it is likely to be flaky. All local runs passed, so I give +1 as verified.
  15. core-ci voted on patch set 7 V +1 09/11/21, 14:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16566

  16. Christian Kuhn voted on patch set 7 V +2 CR +2 09/11/21, 15:50

  17. Christian Kuhn merged patch set 8 09/11/21, 15:50