Review main Merged

70972[TASK] Resolve fatal errors in unit tests under PHP 8.1

crell CR +2 V +2 Easy +0 −7 updated 09/09/21, 11:21

Commit message

PHP 8.1 now includes types on built in class's properties, which means
redeclaring them without types breaks. Let's not do that.

This patch resolves all hard-fatals in unit tests, but not all errors.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. crell uploaded patch set 1 09/08/21, 15:02

  2. core-ci voted on patch set 1 V +1 09/08/21, 15:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16416

  3. Oliver Hader commented on patch set 1 09/08/21, 15:18

    CsvStreamFilter.php:40

    Remove it completely then, as `stream_filter_append` defines `$params` in corresponding `php_user_filter` instance.
  4. crell uploaded patch set 2 09/08/21, 15:20

  5. Oliver Hader voted on patch set 2 CR +1 09/08/21, 15:21

  6. crell commented on patch set 2 09/08/21, 15:21

    CsvStreamFilter.php:40 Reply

    Done
  7. Oliver Hader voted on patch set 2 V +1 09/08/21, 15:21

  8. Stefan Bürk commented on patch set 2 V +1 CR +1 09/08/21, 15:23

    Unit tests at least run completly through, with expected "failing" tests for future patches. Functional starts, but has other fatals. Not blocking this patch, as this is a kickof.
  9. Oliver Klee voted on patch set 2 CR +1 09/08/21, 15:24

  10. core-ci voted on patch set 2 V +1 09/08/21, 15:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16418

  11. Jochen Roth voted on patch set 2 V +1 CR +1 09/09/21, 11:20

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 09/09/21, 11:21

  13. Christian Kuhn merged patch set 3 09/09/21, 11:21