Review main Merged

70973[TASK] Deprecate ext:backend BackendTemplateView

Christian Kuhn CR +2 V +2 Hard +383 −489 updated 09/15/21, 22:36

Commit message

The BackendTemplateView is a - usually Extbase backend
module related - Fluid view that adds a default backend
ModuleTemplate to render backend module content.

That implementation has a couple of drawbacks:
* Using BackendTemplateView hides a dependency to the
  request object by triggering a fallback in ModuleTemplate
  accessing $GLOBALS['TYPO3_REQUEST'].
* Using $this->view->getModuleTemplate() is pretty ugly,
  controllers should work with the ModuleTemplateFactory
  instead and retrieve an instance of ModuleTemplate using
  create($request).
* The level of indirection by having ModuleTemplate within
  the view class magically created makes controller actions
  harder to follow and understand.

With extbase Request nowadays implementing ServerRequestInterface
we can get rid of this indirection: Controllers should get an
instance of ModuleTemplateFactory injected, receive the
ModuleTemplate using ->create($request), and add further
title and doc header related details using that instance.

The patch changes ext:indexed_search, ext:extensionmanager and
ext:form to do that, and deprecates BackendTemplateView.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 20

Review log 2334

Show 59 earlier messages
  1. Christian Kuhn uploaded patch set 1 09/08/21, 15:08

  2. core-ci voted on patch set 1 V +1 09/08/21, 15:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16417

  3. Christian Kuhn uploaded patch set 2 09/08/21, 15:59

  4. core-ci voted on patch set 2 V -1 09/08/21, 16:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16420

  5. Christian Kuhn rebased onto patch set 3 09/09/21, 09:16

  6. core-ci voted on patch set 3 V +1 09/09/21, 09:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16440

  7. Christian Kuhn uploaded patch set 4 09/09/21, 11:49

  8. core-ci voted on patch set 4 V -1 09/09/21, 12:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16446

  9. Christian Kuhn uploaded patch set 5 09/09/21, 13:11

  1. Christian Kuhn updated the commit message in patch set 6 09/09/21, 13:12

  2. Christian Kuhn uploaded patch set 7 09/09/21, 13:15

  3. Oli Bartsch commented on patch set 7 CR -1 09/09/21, 13:35

    IMO we should avoid replacing PSR-17 interfaces by directly initializing PSR-7 wrapper classes.

    Deprecation-95164-ExtbackendBackendTemplateView.rst:88

    HtmlResponse is @internal. Furthermore, such calls should be omitted / replaced by proper usage of PSR-17 interfaces.
  4. core-ci voted on patch set 6 V -1 09/09/21, 13:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16452

  5. core-ci voted on patch set 5 V -1 09/09/21, 13:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16451

  6. core-ci voted on patch set 7 V -1 09/09/21, 13:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16454

  7. Christian Kuhn uploaded patch set 8 09/09/21, 13:46

  8. Christian Kuhn uploaded patch set 9 09/09/21, 14:05

  9. Christian Kuhn commented on patch set 9 09/09/21, 14:06

    Deprecation-95164-ExtbackendBackendTemplateView.rst:88 Reply

    Done
  10. core-ci voted on patch set 8 V -1 09/09/21, 14:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16455

  11. core-ci voted on patch set 9 V -1 09/09/21, 14:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16456

  12. Christian Kuhn uploaded patch set 10 09/09/21, 14:52

  13. core-ci voted on patch set 10 V +1 09/09/21, 15:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16461

  14. Jochen Roth voted on patch set 10 V +1 CR +1 09/09/21, 17:29

  15. Benni Mack commented on patch set 10 CR -1 09/09/21, 20:10

    will check
  16. Georg Ringer commented on patch set 10 CR -2 09/09/21, 20:10

    discussing with benni
  17. Christian Kuhn uploaded patch set 11 09/14/21, 12:19

  18. Christian Kuhn commented on patch set 11 09/14/21, 12:23

    According to Benni, Georg blocked this patch due to the late deprecation in v11: This patch may affect a series of extensions that deliver extbase based backend modules, those extensions already compatible with 11.4 may trigger new deprecation log entries with the patch. I agree to this view and dropped the trigger_error() from BackendTemplateView now: The class is still deprecated, extension scanner will find usages as strong match, but it does not pollute deprecation log.
  19. core-ci voted on patch set 11 V +1 09/14/21, 12:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16698

  20. Georg Ringer voted on patch set 11 CR 0 09/14/21, 13:09

  21. Benni Mack voted on patch set 11 V +1 CR +1 09/14/21, 15:21

  22. Jochen Roth voted on patch set 11 V +1 CR +1 09/15/21, 08:19

  23. Christian Kuhn voted on patch set 11 V +2 CR +2 09/15/21, 08:27

  24. Christian Kuhn merged patch set 12 09/15/21, 08:28

  25. Oli Bartsch commented on patch set 12 09/15/21, 22:36

    Introduces regression, see https://forge.typo3.org/issues/95233