70973[TASK] Deprecate ext:backend BackendTemplateView
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
Files 20
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −0
- typo3/sysext/backend/Classes/View/BackendTemplateView.php+2 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95164-ExtbackendBackendTemplateView.rst2new+93 −0
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/UpgradeCest.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/AbstractModuleController.php+19 −21
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+6 −21
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+12 −25
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+15 −29
- typo3/sysext/extensionmanager/Classes/Controller/ExtensionComposerStatusController.php+21 −61
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+38 −81
- typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php+8 −33
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+6 −21
- typo3/sysext/extensionmanager/Tests/Unit/Controller/ActionControllerTest.php+9 −3
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+5 −2
- typo3/sysext/extensionmanager/Tests/Unit/Controller/UploadExtensionFileControllerTest.php+3 −8
- typo3/sysext/form/Classes/Controller/FormEditorController.php+44 −55
- typo3/sysext/form/Classes/Controller/FormManagerController.php+32 −48
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+63 −73
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+0 −7
Review log 2334
Show 59 earlier messages
-
Christian Kuhn uploaded patch set 1 09/08/21, 15:08
-
core-ci voted on patch set 1 V +1 09/08/21, 15:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16417
-
Christian Kuhn uploaded patch set 2 09/08/21, 15:59
-
core-ci voted on patch set 2 V -1 09/08/21, 16:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16420
-
Christian Kuhn rebased onto patch set 3 09/09/21, 09:16
-
core-ci voted on patch set 3 V +1 09/09/21, 09:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16440
-
Christian Kuhn uploaded patch set 4 09/09/21, 11:49
-
core-ci voted on patch set 4 V -1 09/09/21, 12:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16446
-
Christian Kuhn uploaded patch set 5 09/09/21, 13:11
-
Christian Kuhn updated the commit message in patch set 6 09/09/21, 13:12
-
Christian Kuhn uploaded patch set 7 09/09/21, 13:15
-
Oli Bartsch commented on patch set 7 CR -1 09/09/21, 13:35
IMO we should avoid replacing PSR-17 interfaces by directly initializing PSR-7 wrapper classes.Deprecation-95164-ExtbackendBackendTemplateView.rst:88HtmlResponse is @internal. Furthermore, such calls should be omitted / replaced by proper usage of PSR-17 interfaces. -
core-ci voted on patch set 6 V -1 09/09/21, 13:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16452
-
core-ci voted on patch set 5 V -1 09/09/21, 13:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16451
-
core-ci voted on patch set 7 V -1 09/09/21, 13:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16454
-
Christian Kuhn uploaded patch set 8 09/09/21, 13:46
-
Christian Kuhn uploaded patch set 9 09/09/21, 14:05
-
Christian Kuhn commented on patch set 9 09/09/21, 14:06
Deprecation-95164-ExtbackendBackendTemplateView.rst:88ReplyDone -
core-ci voted on patch set 8 V -1 09/09/21, 14:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16455
-
core-ci voted on patch set 9 V -1 09/09/21, 14:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16456
-
Christian Kuhn uploaded patch set 10 09/09/21, 14:52
-
core-ci voted on patch set 10 V +1 09/09/21, 15:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16461
-
Jochen Roth voted on patch set 10 V +1 CR +1 09/09/21, 17:29
-
Benni Mack commented on patch set 10 CR -1 09/09/21, 20:10
will check -
Georg Ringer commented on patch set 10 CR -2 09/09/21, 20:10
discussing with benni -
Christian Kuhn uploaded patch set 11 09/14/21, 12:19
-
Christian Kuhn commented on patch set 11 09/14/21, 12:23
According to Benni, Georg blocked this patch due to the late deprecation in v11: This patch may affect a series of extensions that deliver extbase based backend modules, those extensions already compatible with 11.4 may trigger new deprecation log entries with the patch. I agree to this view and dropped the trigger_error() from BackendTemplateView now: The class is still deprecated, extension scanner will find usages as strong match, but it does not pollute deprecation log. -
core-ci voted on patch set 11 V +1 09/14/21, 12:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16698
-
Georg Ringer voted on patch set 11 CR 0 09/14/21, 13:09
-
Benni Mack voted on patch set 11 V +1 CR +1 09/14/21, 15:21
-
Jochen Roth voted on patch set 11 V +1 CR +1 09/15/21, 08:19
-
Christian Kuhn voted on patch set 11 V +2 CR +2 09/15/21, 08:27
-
Christian Kuhn merged patch set 12 09/15/21, 08:28
-
Oli Bartsch commented on patch set 12 09/15/21, 22:36
Introduces regression, see https://forge.typo3.org/issues/95233