Review main Merged

70975[TASK] Resolve unit test failures under PHP 8.1

crell CR +2 V +2 Easy +29 −10 updated 09/09/21, 11:16

Commit message

libsodium doesn't support multi-threading. It's unclear why
this code didn't fail previously on 8.0, but sending a thread
count to password_hash() while ext/sodium is enabled is not
supported regardless. I believe this is the least-invasive
fix.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. crell uploaded patch set 1 09/08/21, 19:04

  2. crell commented on patch set 1 09/08/21, 19:15

    This patch leaves a single remaining failure, with GeneralUtilityTest::cmpFqdnReturnsTrue() failing the IPv6 localhost test case. However, we strongly suspect that is caused by an issue in the container, not the code, so posting this now as probably the only change necessary for unit tests.
  3. core-ci voted on patch set 1 V +1 09/08/21, 19:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16426

  4. Oliver Klee voted on patch set 1 CR +1 09/08/21, 19:32

  5. Jochen Roth voted on patch set 1 V +1 CR +1 09/09/21, 11:16

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 09/09/21, 11:16

  7. Christian Kuhn merged patch set 2 09/09/21, 11:16