70977[FEATURE] Introduce <f:transform.html> view-helper
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Lina Wolf +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Lina Wolf +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/DependencyInjection/CommonFactory.phpnew+33 −0
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-95176-IntroduceFtransformhtmlView-helper.rst2new+67 −0
- typo3/sysext/core/composer.json3+2 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Transform/HtmlViewHelper.php3new+116 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Transform/HtmlViewHelperTest.php6new+206 −0
- typo3/sysext/frontend/Classes/Html/HtmlWorker.phpnew+180 −0
- typo3/sysext/frontend/Classes/Typolink/LinkResultFactory.phpnew+62 −0
- typo3/sysext/frontend/Configuration/Services.yaml+6 −0
- composer.json+2 −0
- composer.lock+2 −1
Review log 3755
Show 1830 earlier messages
-
Oliver Hader uploaded patch set 1 09/08/21, 21:59
-
core-ci voted on patch set 1 V +1 09/08/21, 22:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16429
-
Oliver Hader uploaded patch set 2 09/10/21, 13:23
-
Oliver Hader updated the commit message in patch set 3 09/10/21, 13:24
-
core-ci voted on patch set 3 V +1 09/10/21, 13:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16485
-
core-ci voted on patch set 2 V +1 09/10/21, 13:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16484
-
Oliver Hader uploaded patch set 4 09/10/21, 13:55
-
Oliver Hader uploaded patch set 5 09/10/21, 14:04
-
core-ci voted on patch set 4 V +1 09/10/21, 14:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16488
-
core-ci voted on patch set 5 V +1 09/10/21, 14:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16490
-
Chris Müller commented on patch set 5 09/10/21, 19:24
-
Oliver Hader updated the commit message in patch set 6 09/10/21, 20:01
-
Oliver Hader commented on patch set 7 09/10/21, 20:02
Published edit on patch set 6. -
Oliver Hader commented on patch set 7 09/10/21, 20:03
Feature-95176-IntroduceFtransformhtmlView-helper.rst:46ReplyCorrect, thx! Patch was adjusted -
core-ci voted on patch set 6 V +1 09/10/21, 20:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16511
-
core-ci voted on patch set 7 V +1 09/10/21, 20:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16512
-
Sybille Peters uploaded patch set 8 09/12/21, 07:36
-
core-ci voted on patch set 8 V +1 09/12/21, 07:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16594
-
Sybille Peters commented on patch set 8 09/12/21, 08:10
composer.json:42This patch changes the core extension "fluid". Shouldn't the changes in composer.json be done in the composer.json of that extension (instead of in core extension)? Even though you will most likely always use fluid, it seems a bit "cleaner" that way. -
Benni Mack commented on patch set 8 09/13/21, 13:14
HtmlViewHelper.php:154how about moving this logic to EXT:frontend (e.g. "LinkGenerator") and have the VH only access the API class? This way, we could use this in other places too -
Oliver Hader commented on patch set 8 09/14/21, 07:06
composer.json:42Reply`masterminds/html5` is implicitly used by `typo3/html-sanitizer` already in `typo3/cms-core`. This change just makes the requirement explicit.HtmlViewHelper.php:154ReplyHm... difficult with naming, "generator", "builder", "service"... What about `TYPO3\CMS\Frontend\TypoLink\LinkResultFactory::fromUri($uri)`? -
Oliver Hader uploaded patch set 9 09/14/21, 07:40
-
Oliver Hader uploaded patch set 10 09/14/21, 07:47
-
core-ci voted on patch set 9 V +1 09/14/21, 07:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16685
-
core-ci voted on patch set 10 V +1 09/14/21, 08:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16686
-
Oliver Hader uploaded patch set 11 09/14/21, 20:27
-
Oliver Hader uploaded patch set 12 09/14/21, 20:30
-
core-ci voted on patch set 11 V -1 09/14/21, 20:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16721
-
core-ci voted on patch set 12 V +1 09/14/21, 20:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16722
-
Oliver Hader commented on patch set 12 09/14/21, 20:53
HtmlViewHelperTest.php:99Not sure whether invalid page uid values, should be removed (blank string) or kept (passed through)...
-
Benni Mack commented on patch set 12 09/16/21, 10:19
HtmlViewHelperTest.php:99ReplyTYPO3 usually removes the <a>Blabla</a> and just writes "Blabla" then (default behaviour in frontend) -
Oliver Hader commented on patch set 12 09/16/21, 12:22
HtmlViewHelperTest.php:99ReplyI read that as "yes, make sure invalid URIs are removed"... -
Oliver Hader uploaded patch set 13 09/16/21, 12:32
-
core-ci voted on patch set 13 V +1 09/16/21, 12:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16798
-
Benni Mack commented on patch set 13 09/16/21, 15:13
HtmlViewHelper.php:154ReplyDoneHtmlViewHelperTest.php:99ReplyNo, it does not add the <a> tag at all. just "visit" -
Oliver Hader uploaded patch set 14 09/17/21, 20:33
-
Oliver Hader commented on patch set 14 09/17/21, 20:34
HtmlViewHelperTest.php:99ReplyOkay... added a new behavior `removeEnclosure` which does exactly this... -
Oliver Hader commented on patch set 14 09/17/21, 20:42
composer.json:42ReplyDoneHtmlViewHelperTest.php:99ReplyDone -
core-ci voted on patch set 14 V -1 09/17/21, 20:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16892
-
Oliver Hader uploaded patch set 15 09/17/21, 20:55
-
core-ci voted on patch set 15 V +1 09/17/21, 21:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16894
-
Lina Wolf commented on patch set 15 CR -1 09/19/21, 13:31
Working on this -
Lina Wolf uploaded patch set 16 09/19/21, 13:36
-
Lina Wolf commented on patch set 16 V +1 09/19/21, 13:47
I tried it out by integrating the example from the Changelog into the template of the site_package example extension. Worked fine. -
Lina Wolf commented on patch set 16 CR +1 09/19/21, 13:49
The code looks fine to me, but someone else should have a look -
core-ci voted on patch set 16 V +1 09/19/21, 13:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16918
-
Oliver Hader commented on patch set 17 09/19/21, 14:09
Published edit on patch set 16. -
Oliver Hader commented on patch set 18 09/19/21, 14:10
Published edit on patch set 17. -
core-ci voted on patch set 18 V +1 09/19/21, 14:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16920
-
core-ci voted on patch set 17 V +1 09/19/21, 14:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16919
-
Benni Mack voted on patch set 18 V +1 CR +1 09/20/21, 07:33
-
Lina Wolf commented on patch set 18 CR +1 09/20/21, 07:55
Code Looks good to me -
Lina Wolf commented on patch set 18 V +1 09/20/21, 07:57
And works ok as described above -
Oliver Hader voted on patch set 18 V +2 CR +2 09/20/21, 08:07
-
Oliver Hader merged patch set 19 09/20/21, 08:07
Feature-95176-IntroduceFtransformhtmlView-helper.rst:46