Review main Merged

70978[BUGIFX] Clipboard panel as web component

Oli Bartsch CR +2 V +2 Hard +666 −311 updated 09/21/21, 16:10

Commit message

The clipboard component still suffers a lot of
problems, due to its static integration in the list
modules.

For example, when clearing the clipboard, it's no
longer possible to copy / cut a record via context
menu, since the the previous GET parameters are
included in the return URL, directly reverting the
operation.

The list modules should therefore not longer handle
any clipboard logic directly, especially not via GET.

This patch does the first step towards this goal and
introduces a dedicated endpoint, only available via
POST. The clipboard panel, used in recordlist and
filelist is furthermore now integrated as a web
component, making any form submit in the main module
superfluous.

Additionally some related bugs are fixed:

* Elements moved to clipboard via context menu can now
  be remvoed from clipboard again
* Non related elements are now always properly styled
* File elements now correctly link to their parent folder in filelist
* Buttons are only shown for the clipboard they influence

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 19

Review log 1624

  1. Oli Bartsch uploaded patch set 1 09/09/21, 00:00

  2. core-ci voted on patch set 1 V -1 09/09/21, 00:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16430

  3. Oli Bartsch uploaded patch set 2 09/14/21, 23:49

  4. Oli Bartsch uploaded patch set 3 09/15/21, 00:01

  5. core-ci voted on patch set 2 V -1 09/15/21, 00:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16726

  6. core-ci voted on patch set 3 V -1 09/15/21, 00:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16727

  7. Oli Bartsch uploaded patch set 4 09/15/21, 13:32

  8. core-ci voted on patch set 4 V -1 09/15/21, 13:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16741

  9. Oli Bartsch uploaded patch set 5 09/17/21, 12:18

  10. core-ci voted on patch set 5 V -1 09/17/21, 12:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16874

  11. Oli Bartsch uploaded patch set 6 09/17/21, 14:57

  12. core-ci voted on patch set 6 V -1 09/17/21, 15:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16881

  13. Oli Bartsch uploaded patch set 7 09/17/21, 16:34

  14. core-ci voted on patch set 7 V +1 09/17/21, 16:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16888

  15. Benni Mack voted on patch set 7 V +1 CR +1 09/21/21, 11:05

  16. Oliver Hader voted on patch set 7 V +1 09/21/21, 14:18

  17. Oliver Hader commented on patch set 7 CR +1 09/21/21, 14:46

    I had some nitpicks... but in general it's really good as it is!

    ClipboardPanel.ts:67

    Nitpick: HTML attrs are case insensitive, in order to bind other attrs to props. Allowing attr `return-url` being mapped to prop `returnUrl`, corresponding `attribute` declaration can be used, see https://lit-element.polymer-project.org/api/interfaces/_lit_element_.propertydeclaration.html#attribute

    ClipboardPanel.ts:96

    In general: `catch` block is missing, in case server-side request fails (can be simulated by throwing an exception in `ClipboardController`).

    ClipboardPanel.ts:199

    `callback` current does not seem to be used, is it?
  18. Oli Bartsch uploaded patch set 8 09/21/21, 15:33

  19. Oli Bartsch commented on patch set 8 09/21/21, 15:34

    ClipboardPanel.ts:67 Reply

    Done

    ClipboardPanel.ts:96 Reply

    Done

    ClipboardPanel.ts:199 Reply

    Done
  20. Oliver Hader commented on patch set 8 V +1 CR +1 09/21/21, 15:41

    Thx for incorporating the changes! 👍
  21. core-ci voted on patch set 8 V +1 09/21/21, 15:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16997

  22. Benni Mack voted on patch set 8 V +1 CR +1 09/21/21, 15:51

  23. Oli Bartsch voted on patch set 8 V +2 CR +2 09/21/21, 16:10

  24. Oli Bartsch merged patch set 9 09/21/21, 16:10