70978[BUGIFX] Clipboard panel as web component
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Hader +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 19
- Build/Sources/Sass/typo3/_element_table.scss+3 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ClipboardPanel.ts6new+238 −0
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/ContextMenuActions.ts+8 −8
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+146 −171
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −0
- typo3/sysext/backend/Classes/Controller/ClipboardController.phpnew+114 −0
- typo3/sysext/backend/Configuration/Backend/Routes.php+7 −0
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Resources/Private/Partials/Clipboard/TabContent.htmldeleted+0 −46
- typo3/sysext/backend/Resources/Private/Templates/Clipboard/Main.htmldeleted+0 −69
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ClipboardPanel.jsnew+104 −0
- typo3/sysext/backend/Tests/Functional/Clipboard/ClipboardTest.php+22 −3
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+3 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+9 −5
- typo3/sysext/filelist/Classes/Controller/FileListController.php+2 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+2 −2
- typo3/sysext/filelist/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+2 −1
Review log 1624
-
Oli Bartsch uploaded patch set 1 09/09/21, 00:00
-
core-ci voted on patch set 1 V -1 09/09/21, 00:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16430
-
Oli Bartsch uploaded patch set 2 09/14/21, 23:49
-
Oli Bartsch uploaded patch set 3 09/15/21, 00:01
-
core-ci voted on patch set 2 V -1 09/15/21, 00:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16726
-
core-ci voted on patch set 3 V -1 09/15/21, 00:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16727
-
Oli Bartsch uploaded patch set 4 09/15/21, 13:32
-
core-ci voted on patch set 4 V -1 09/15/21, 13:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16741
-
Oli Bartsch uploaded patch set 5 09/17/21, 12:18
-
core-ci voted on patch set 5 V -1 09/17/21, 12:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16874
-
Oli Bartsch uploaded patch set 6 09/17/21, 14:57
-
core-ci voted on patch set 6 V -1 09/17/21, 15:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16881
-
Oli Bartsch uploaded patch set 7 09/17/21, 16:34
-
core-ci voted on patch set 7 V +1 09/17/21, 16:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16888
-
Benni Mack voted on patch set 7 V +1 CR +1 09/21/21, 11:05
-
Oliver Hader voted on patch set 7 V +1 09/21/21, 14:18
-
Oliver Hader commented on patch set 7 CR +1 09/21/21, 14:46
I had some nitpicks... but in general it's really good as it is!ClipboardPanel.ts:67Nitpick: HTML attrs are case insensitive, in order to bind other attrs to props. Allowing attr `return-url` being mapped to prop `returnUrl`, corresponding `attribute` declaration can be used, see https://lit-element.polymer-project.org/api/interfaces/_lit_element_.propertydeclaration.html#attributeClipboardPanel.ts:96In general: `catch` block is missing, in case server-side request fails (can be simulated by throwing an exception in `ClipboardController`).ClipboardPanel.ts:199`callback` current does not seem to be used, is it? -
Oli Bartsch uploaded patch set 8 09/21/21, 15:33
-
Oli Bartsch commented on patch set 8 09/21/21, 15:34
ClipboardPanel.ts:67ReplyDoneClipboardPanel.ts:96ReplyDoneClipboardPanel.ts:199ReplyDone -
Oliver Hader commented on patch set 8 V +1 CR +1 09/21/21, 15:41
Thx for incorporating the changes! 👍 -
core-ci voted on patch set 8 V +1 09/21/21, 15:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16997
-
Benni Mack voted on patch set 8 V +1 CR +1 09/21/21, 15:51
-
Oli Bartsch voted on patch set 8 V +2 CR +2 09/21/21, 16:10
-
Oli Bartsch merged patch set 9 09/21/21, 16:10