Review main Merged

70979[BUGFIX] Skip localize option in language switch

Jochen Roth CR +2 V +2 Easy +12 −9 updated 09/20/21, 15:19

Commit message

The language switch in FormEngine allows
to either switch to an existing translation
of the current record, or to create such a
translation. This however currently does only
work in case a default language record exists.

Therefore, in case no default record exists,
the "localize" option is skipped for the record,
preventing PHP warnings.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1827

Show 2 earlier messages
  1. Jochen Roth uploaded patch set 1 09/09/21, 07:07

  2. Jochen Roth uploaded patch set 2 09/09/21, 07:15

  1. core-ci voted on patch set 1 V +1 09/09/21, 07:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16434

  2. core-ci voted on patch set 2 V +1 09/09/21, 07:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16435

  3. Achim Fritz voted on patch set 2 V +1 CR +1 09/09/21, 07:32

  4. Jochen Roth uploaded patch set 3 09/09/21, 09:09

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 09/09/21, 09:10

  6. Oli Bartsch commented on patch set 3 09/09/21, 09:12

    EditDocumentController.php:2169 Unresolved

    Does this make any sense at all if no UID is available?
  7. Achim Fritz voted on patch set 3 V +1 CR +1 09/09/21, 09:13

  8. core-ci voted on patch set 3 V +1 09/09/21, 09:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16439

  9. Oli Bartsch voted on patch set 3 CR -1 09/09/21, 09:29

  10. Oli Bartsch uploaded patch set 4 09/09/21, 09:51

  11. core-ci voted on patch set 4 V -1 09/09/21, 10:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16442

  12. core-ci commented on patch set 4 09/09/21, 10:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16442

  13. core-ci commented on patch set 4 09/09/21, 11:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16442

  14. Jochen Roth rebased onto patch set 5 09/09/21, 15:22

  15. core-ci voted on patch set 5 V +1 09/09/21, 15:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16463

  16. Benni Mack commented on patch set 5 09/09/21, 15:58

  17. Oli Bartsch voted on patch set 5 V +1 CR +1 09/10/21, 00:24

  18. Jochen Roth voted on patch set 5 V +1 CR +1 09/10/21, 06:58

  19. Jochen Roth uploaded patch set 6 09/12/21, 17:25

  20. core-ci voted on patch set 6 V -1 09/12/21, 17:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16628

  21. Jochen Roth rebased onto patch set 7 09/15/21, 07:47

  22. core-ci voted on patch set 7 V +1 09/15/21, 08:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16734

  23. Oli Bartsch voted on patch set 7 V +1 CR +1 09/20/21, 09:22

  24. Benni Mack voted on patch set 7 V +2 CR +2 09/20/21, 15:19

  25. Benni Mack merged patch set 8 09/20/21, 15:19