Review main Merged

70980[BUGFIX] Render HTML tags in CSH

Georg Ringer CR +2 V +2 Normal +107 −4 updated 10/12/21, 08:29

Commit message

Allow a list of HTML tags in the help content just as for
the configuration details.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2332

Show 47 earlier messages
  1. Georg Ringer uploaded patch set 1 09/09/21, 07:32

  2. Georg Ringer commented on patch set 1 09/09/21, 07:32

    This change is ready for review.
  3. Josef Glatz updated the commit message in patch set 2 09/09/21, 07:42

  4. core-ci voted on patch set 1 V -1 09/09/21, 07:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16436

  5. core-ci voted on patch set 2 V +1 09/09/21, 07:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16437

  6. Georg Ringer rebased onto patch set 3 10/08/21, 08:11

  7. core-ci voted on patch set 3 V +1 10/08/21, 08:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17798

  1. Wouter Wolters voted on patch set 3 V +1 CR +1 10/11/21, 17:35

  2. Benni Mack voted on patch set 3 V +1 CR +1 10/11/21, 18:11

  3. Benni Mack commented on patch set 3 V 0 CR 0 10/11/21, 18:12

  4. Oliver Hader voted on patch set 3 CR -1 10/11/21, 18:33

  5. Oliver Hader commented on patch set 3 10/11/21, 18:39

    I suggest to replace all these `strip_tags` things with using proper HTML sanitization: https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5.x/Feature-94825-SanitizeHtmlFluidViewHelper.html#feature-94825-new-f-sanitize-html-fluid-viewhelper * create new Sanitizer builder "i18n", just allowing a few tags, e.g. `a,em,strong,..." * use new `<f:sanitize.html build="i18n">{languageLabel}</f:sanitize.html>` instead of `strip_tags`
  6. Oliver Hader commented on patch set 3 10/11/21, 18:46

    On it...
  7. Oliver Hader uploaded patch set 4 10/11/21, 19:15

  8. Oliver Hader commented on patch set 4 10/11/21, 19:16

    Which CSH elements are rendering HTML currently?

    Manual.html:7 Reply

    Ack
  9. Oliver Hader commented on patch set 4 10/11/21, 19:21

    Found `tt_content.colPos`... won't search for for encoded HTML entities in XML files... 😄
  10. Oliver Hader uploaded patch set 5 10/11/21, 19:23

  11. Oliver Hader uploaded patch set 6 10/11/21, 19:28

  12. core-ci voted on patch set 4 V -1 10/11/21, 19:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17934

  13. Oliver Hader uploaded patch set 7 10/11/21, 19:45

  14. core-ci voted on patch set 5 V -1 10/11/21, 19:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17936

  15. core-ci voted on patch set 7 V -1 10/11/21, 19:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17939

  16. core-ci voted on patch set 6 V -1 10/11/21, 19:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17937

  17. Oliver Hader uploaded patch set 8 10/11/21, 19:57

  18. core-ci voted on patch set 8 V -1 10/11/21, 20:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17940

  19. Oliver Hader uploaded patch set 9 10/11/21, 20:51

  20. core-ci voted on patch set 9 V +1 10/11/21, 21:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17944

  21. Benni Mack commented on patch set 9 V +1 CR +1 10/12/21, 06:18

    verified now.
  22. Georg Ringer voted on patch set 9 V +1 CR +1 10/12/21, 06:33

  23. Benni Mack commented on patch set 9 V 0 CR 0 10/12/21, 07:02

    I think we need a bit more work here.
  24. Benni Mack voted on patch set 9 V +2 CR +2 10/12/21, 08:29

  25. Benni Mack merged patch set 10 10/12/21, 08:29