Review main Merged

70981[BUGFIX] Handle function switch in page module

Oli Bartsch CR +2 V +2 Easy +5 −0 updated 09/09/21, 11:59

Commit message

Switching from "Languages" to "Columns" mode
in the page module, while having "All languages"
selected, the grid was previously empty, due to
a missing fallback.

The special "-1" is no valid language id in the
"Columns" mode and has to be replaced in
the module settings. We therefore fall back
to the default language, which is in this case
already visually selected for the user, since it's
the first module menu entry.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 09/09/21, 10:57

  2. core-ci voted on patch set 1 V +1 09/09/21, 11:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16443

  3. Benni Mack updated the commit message in patch set 2 09/09/21, 11:16

  4. core-ci voted on patch set 2 V +1 09/09/21, 11:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16445

  5. Benni Mack voted on patch set 2 V +1 CR +1 09/09/21, 11:49

  6. Georg Ringer voted on patch set 2 V +2 CR +2 09/09/21, 11:59

  7. Georg Ringer merged patch set 3 09/09/21, 11:59