Review main Merged

70982[BUGFIX] Avoid trigger_error for "rootUid" related methods

Oli Bartsch CR +2 V +2 Easy +6 −7 updated 09/09/21, 13:00

Commit message

In #95037 the "rootUid" option has been deprecated
in favour of "startingPoints", which now allows to add
multiple root nodes for a tree.

However, for backwards compatibility, the "rootUid"
option is still used in core. The corresponding setter
and getter methods should therefore not trigger a
deprecation log entry. Extension scanner still finds
usages in extension code as weak match.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 56

  1. Oli Bartsch uploaded patch set 1 09/09/21, 12:01

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 09/09/21, 12:02

  3. core-ci voted on patch set 1 V +1 09/09/21, 12:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16447

  4. Jochen Roth voted on patch set 1 V +1 CR +1 09/09/21, 12:58

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 09/09/21, 13:00

  6. Oli Bartsch merged patch set 2 09/09/21, 13:00