Review main Merged

70985[BUGFIX] Make ExtensionComposer status link in reports a button

Jochen Roth CR +2 V +2 Easy +6 −6 updated 09/21/21, 14:27

Commit message

Links without a target are actually buttons. Previously, the
"Update extension" link in the reports module was furthermore
removed while parsing, due to the missing target.

Therefore this patch transforms the "link", which is using the
ActionDispatcher, to be a button.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1419

  1. Jochen Roth uploaded patch set 1 09/09/21, 15:17

  2. Oliver Klee voted on patch set 1 CR +1 09/09/21, 15:22

  3. core-ci voted on patch set 1 V +1 09/09/21, 15:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16462

  4. Oli Bartsch commented on patch set 1 CR -1 09/10/21, 00:35

    ExtensionComposerStatus.php:89

    Please always define "type=button" if the button should not be used to submit a form. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-type FYI the "problem" with the link will be tackled separately: https://forge.typo3.org/issues/95158. This is due to the reports template is using <f:format.html parseFuncTSPath=""> for rendering the content. This currently also leads to a deprecation log entry triggered, when accessing reports module.
  5. Jochen Roth uploaded patch set 2 09/10/21, 06:33

  6. Jochen Roth commented on patch set 2 09/10/21, 06:44

    ExtensionComposerStatus.php:89 Reply

    Added `type=button` which is removed by the parser as well. I think we merge this now coz the button is working for the user even though it's not correct html. I prefer the button over the link. Once #95158 is done we can revisit this. Thanks for the details.
  7. core-ci voted on patch set 2 V +1 09/10/21, 06:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16472

  8. Oliver Klee voted on patch set 2 CR +1 09/10/21, 09:39

  9. Jochen Roth rebased onto patch set 3 09/15/21, 08:01

  10. core-ci voted on patch set 3 V +1 09/15/21, 08:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16736

  11. Jochen Roth commented on patch set 3 09/15/21, 08:35

    ExtensionComposerStatus.php:89 Reply

    #95158 got merged, so this should be ready.
  12. Oli Bartsch uploaded patch set 4 09/20/21, 09:01

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 09/20/21, 09:02

  14. Oli Bartsch updated the commit message in patch set 5 09/20/21, 09:04

  15. Oli Bartsch voted on patch set 5 V +1 CR +1 09/20/21, 09:04

  16. core-ci voted on patch set 4 V +1 09/20/21, 09:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16929

  17. core-ci voted on patch set 5 V +1 09/20/21, 09:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16930

  18. Benni Mack voted on patch set 5 V +2 CR +2 09/21/21, 14:27

  19. Benni Mack merged patch set 6 09/21/21, 14:27