70985[BUGFIX] Make ExtensionComposer status link in reports a button
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1419
-
Jochen Roth uploaded patch set 1 09/09/21, 15:17
-
Oliver Klee voted on patch set 1 CR +1 09/09/21, 15:22
-
core-ci voted on patch set 1 V +1 09/09/21, 15:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16462
-
Oli Bartsch commented on patch set 1 CR -1 09/10/21, 00:35
-
Jochen Roth uploaded patch set 2 09/10/21, 06:33
-
Jochen Roth commented on patch set 2 09/10/21, 06:44
ExtensionComposerStatus.php:89ReplyAdded `type=button` which is removed by the parser as well. I think we merge this now coz the button is working for the user even though it's not correct html. I prefer the button over the link. Once #95158 is done we can revisit this. Thanks for the details. -
core-ci voted on patch set 2 V +1 09/10/21, 06:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16472
-
Oliver Klee voted on patch set 2 CR +1 09/10/21, 09:39
-
Jochen Roth rebased onto patch set 3 09/15/21, 08:01
-
core-ci voted on patch set 3 V +1 09/15/21, 08:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16736
-
Jochen Roth commented on patch set 3 09/15/21, 08:35
ExtensionComposerStatus.php:89Reply#95158 got merged, so this should be ready. -
Oli Bartsch uploaded patch set 4 09/20/21, 09:01
-
Oli Bartsch voted on patch set 4 V +1 CR +1 09/20/21, 09:02
-
Oli Bartsch updated the commit message in patch set 5 09/20/21, 09:04
-
Oli Bartsch voted on patch set 5 V +1 CR +1 09/20/21, 09:04
-
core-ci voted on patch set 4 V +1 09/20/21, 09:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16929
-
core-ci voted on patch set 5 V +1 09/20/21, 09:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16930
-
Benni Mack voted on patch set 5 V +2 CR +2 09/21/21, 14:27
-
Benni Mack merged patch set 6 09/21/21, 14:27
ExtensionComposerStatus.php:89