71013[TASK] Add missing configuration options for file download
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 2
Files 12
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/ContextMenuActions.ts+10 −1
- Build/Sources/TypeScript/filelist/Resources/Public/TypeScript/FileList.ts+8 −1
- typo3/sysext/core/Classes/Resource/Filter/FileExtensionFilter.php+2 −1
- typo3/sysext/core/Documentation/Changelog/11.4/Feature-90548-DownloadMultipleFilesAndFoldersInFilelist.rst+18 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+9 −0
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+26 −1
- typo3/sysext/filelist/Classes/Controller/FileDownloadController.php2+45 −14
- typo3/sysext/filelist/Classes/Controller/FileListController.php+12 −5
- typo3/sysext/filelist/Classes/FileList.php+28 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+6 −4
- typo3/sysext/filelist/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/FileList.js+1 −1
Review log 1116
-
Oli Bartsch uploaded patch set 1 09/10/21, 00:11
-
core-ci voted on patch set 1 V +1 09/10/21, 00:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16468
-
Jochen Roth commented on patch set 1 V +1 CR +1 09/10/21, 09:42
It would be nice to let the user know before the download which files are not included. In my case i tried to download only files my user had no permission to download which still downloaded a zip file containing only a file saying "No files found.txt" Despite that it's looking good. -
Oli Bartsch uploaded patch set 2 09/10/21, 11:45
-
Oli Bartsch uploaded patch set 3 09/10/21, 11:54
-
Oli Bartsch commented on patch set 3 09/10/21, 11:57
Reply
Thanks for your review. I adjusted the functionality. Now, in case the zip is empty, no download will be triggered and a notification will be displayed, informing the user about this. -
core-ci voted on patch set 2 V +1 09/10/21, 12:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16477
-
core-ci voted on patch set 3 V -1 09/10/21, 12:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16478
-
core-ci voted on patch set 3 V +1 09/10/21, 12:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16478
-
Benni Mack commented on patch set 3 09/10/21, 12:37
FileDownloadController.php:61if this feature is not enabled, we need a 403. -
Oli Bartsch uploaded patch set 4 09/10/21, 13:15
-
Oli Bartsch commented on patch set 4 09/10/21, 13:15
FileDownloadController.php:61ReplyDone -
core-ci voted on patch set 4 V +1 09/10/21, 13:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16481
-
Jochen Roth voted on patch set 4 V +1 CR +1 09/12/21, 14:08
-
Benni Mack voted on patch set 4 V +2 CR +2 09/13/21, 06:44
-
Benni Mack merged patch set 5 09/13/21, 06:44