Review main Merged

71013[TASK] Add missing configuration options for file download

Oli Bartsch CR +2 V +2 Normal +166 −32 updated 09/13/21, 06:44

Commit message

With #90548 the filelist module has been extended
for the possibility to download files and folders.

Since file download might not be enabled for all
users, or should at least be limited to a set of
file extensions, this patch adds the necessary
configuration options.

It's therefore now possible to either specify
allowed / disallowed file extensions or to
completely disable the file download.

In case the download can not be prepared due
to no valid files were found, the user
receives a notification.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 1116

  1. Oli Bartsch uploaded patch set 1 09/10/21, 00:11

  2. core-ci voted on patch set 1 V +1 09/10/21, 00:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16468

  3. Jochen Roth commented on patch set 1 V +1 CR +1 09/10/21, 09:42

    It would be nice to let the user know before the download which files are not included. In my case i tried to download only files my user had no permission to download which still downloaded a zip file containing only a file saying "No files found.txt" Despite that it's looking good.
  4. Oli Bartsch uploaded patch set 2 09/10/21, 11:45

  5. Oli Bartsch uploaded patch set 3 09/10/21, 11:54

  6. Oli Bartsch commented on patch set 3 09/10/21, 11:57

    Reply

    Thanks for your review. I adjusted the functionality. Now, in case the zip is empty, no download will be triggered and a notification will be displayed, informing the user about this.
  7. core-ci voted on patch set 2 V +1 09/10/21, 12:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16477

  8. core-ci voted on patch set 3 V -1 09/10/21, 12:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16478

  9. core-ci voted on patch set 3 V +1 09/10/21, 12:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16478

  10. Benni Mack commented on patch set 3 09/10/21, 12:37

    FileDownloadController.php:61

    if this feature is not enabled, we need a 403.
  11. Oli Bartsch uploaded patch set 4 09/10/21, 13:15

  12. Oli Bartsch commented on patch set 4 09/10/21, 13:15

    FileDownloadController.php:61 Reply

    Done
  13. core-ci voted on patch set 4 V +1 09/10/21, 13:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16481

  14. Jochen Roth voted on patch set 4 V +1 CR +1 09/12/21, 14:08

  15. Benni Mack voted on patch set 4 V +2 CR +2 09/13/21, 06:44

  16. Benni Mack merged patch set 5 09/13/21, 06:44