Review main Merged

71015[BUGFIX] Resolve site configuration in FlexForm

Andreas Kienast CR +2 V +2 Easy +12 −7 updated 10/05/21, 15:56

Commit message

Within `flexFormSegment`, the missing `SiteResolving` configuration is
included to gain access to the resolved site configuration in FlexForms.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Andreas Kienast uploaded patch set 1 09/10/21, 11:22

  2. Andreas Kienast commented on patch set 1 09/10/21, 11:31

    Honestly, I'm unsure how to cover this with tests properly.
  3. core-ci voted on patch set 1 V +1 09/10/21, 11:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16476

  4. Andreas Kienast uploaded patch set 2 09/27/21, 06:21

  5. Andreas Kienast uploaded patch set 3 09/27/21, 06:22

  6. core-ci voted on patch set 2 V +1 09/27/21, 06:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17204

  7. core-ci voted on patch set 3 V +1 09/27/21, 06:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17205

  8. Andreas Kienast updated the commit message in patch set 4 10/05/21, 06:50

  9. core-ci voted on patch set 4 V +1 10/05/21, 07:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17596

  10. Benni Mack voted on patch set 4 V +1 CR +1 10/05/21, 08:36

  11. Oli Bartsch voted on patch set 4 V +2 CR +2 10/05/21, 15:56

  12. Oli Bartsch merged patch set 5 10/05/21, 15:56