Review main Merged

71016[TASK] Avoid pagination controls for single page listings

Oli Bartsch CR +2 V +2 Hard +362 −362 updated 09/13/21, 13:02

Commit message

In case a paginated listing does only contain records
for one page, the pagination controls do not make any
sense and will at worst just confuse editors.

This patch therefore adds consistency to the backend
modules by only showing pagination controls if the
number of paginated pages is greater than one.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jonas Eberle +1
    • Sybille Peters +1
    • Benni Mack +1
    • Rachel Foucard +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jonas Eberle +1
    • Sybille Peters +1
    • Benni Mack +1
    • Rachel Foucard +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1215

  1. Oli Bartsch uploaded patch set 1 09/10/21, 12:58

  2. core-ci voted on patch set 1 V -1 09/10/21, 13:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16480

  3. Oli Bartsch uploaded patch set 2 09/10/21, 13:29

  4. core-ci voted on patch set 2 V +1 09/10/21, 13:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16486

  5. Sybille Peters uploaded patch set 3 09/12/21, 05:20

  6. Sybille Peters commented on patch set 3 09/12/21, 05:24

    Fixed merge conflicts due to acceptance test.
  7. core-ci voted on patch set 3 V +1 09/12/21, 05:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16587

  8. Sybille Peters voted on patch set 3 V +1 CR +1 09/12/21, 06:10

  9. Sybille Peters commented on patch set 3 09/12/21, 06:14

    I added another issue because I find it's weird that the pagination controls sometimes appear on the top and sometimes on the bottom: https://forge.typo3.org/issues/95192 But probably that should be handled in another patch to keep this focused on the deactivation of the controls if there is only one page. (Also, maybe there is good reason for doing this differently, but in the case of the BE users I almost missed that there was a pagination option). I tested by changing the respective limits in the controllers.
  10. Jonas Eberle voted on patch set 3 V +1 CR +1 09/12/21, 14:26

  11. Rachel Foucard voted on patch set 3 V +1 CR +1 09/12/21, 15:05

  12. Benni Mack voted on patch set 3 CR +1 09/13/21, 06:58

  13. Benni Mack voted on patch set 3 V +1 09/13/21, 13:01

  14. Oli Bartsch voted on patch set 3 V +2 CR +2 09/13/21, 13:02

  15. Oli Bartsch merged patch set 4 09/13/21, 13:02