Review main Merged

71017[TASK] Use executeFrontendSubRequest() for SecureHtmlRenderingTest

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 09/10/21, 14:04

Commit message

Executing frontend request calls in tests has been transformed to
the new subrequest support of v11.

One test has been added with old executeFrontendRequest() which is
deprecated in the testing-framework and is changed to the new
executeFrontendSubRequest() ability.

This patch acts as post-patch to change this for master.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Stefan Bürk uploaded patch set 1 09/10/21, 13:17

  2. Andreas Kienast updated the commit message in patch set 2 09/10/21, 13:18

  3. Andreas Kienast voted on patch set 2 CR +1 09/10/21, 13:18

  4. core-ci voted on patch set 1 V +1 09/10/21, 13:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16482

  5. core-ci voted on patch set 2 V +1 09/10/21, 13:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16483

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 09/10/21, 13:47

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 09/10/21, 14:04

  8. Andreas Kienast merged patch set 3 09/10/21, 14:04