Review main Merged

71023[BUGFIX] Avoid endless loading of FormEngine

Oli Bartsch CR +2 V +2 Hard +218 −190 updated 09/16/21, 11:14

Commit message

EditDocumentController failed to properly track if
the edit form could be created or not. This lead
to a couple of consequential errors. For example,
the spinner was added but could never be removed,
since the FormEngine JavaScript component was not
initialized.

With PHP > 8 this also lead to a lot of warnings
since $this->firstEl is not set, in case the edit
form could not be created.

This is now fixed by properly tracking whether the
edit form was created and whether $this->firstEl
was initialized. In case the edit form could not
be created, an info box notifies the user.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 812

  1. Oli Bartsch uploaded patch set 1 09/10/21, 15:35

  2. Oli Bartsch uploaded patch set 2 09/10/21, 15:44

  3. core-ci voted on patch set 1 V +1 09/10/21, 15:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16498

  4. core-ci voted on patch set 2 V +1 09/10/21, 16:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16502

  5. Oli Bartsch updated the commit message in patch set 3 09/10/21, 17:07

  6. core-ci voted on patch set 3 V +1 09/10/21, 17:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16506

  7. Stephan Großberndt updated the commit message in patch set 4 09/10/21, 17:28

  8. core-ci voted on patch set 4 V +1 09/10/21, 17:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16507

  9. Jochen Roth voted on patch set 4 V +1 CR +1 09/12/21, 15:38

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 09/16/21, 11:14

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 09/16/21, 11:14

  12. Christian Kuhn merged patch set 5 09/16/21, 11:14