Review main Merged

71024[FOLLOWUP] Document how to use extensions as Composer root for testing

Oliver Klee CR +2 V +2 Easy +24 −8 updated 09/17/21, 21:06

Commit message

Also polish the language of the related ReST file a bit.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benni Mack +1
    • core-ci +1 CI

Files 1

Review log 1011

  1. Oliver Klee uploaded patch set 1 09/10/21, 16:19

  2. core-ci voted on patch set 1 V +1 09/10/21, 16:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16504

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/10/21, 17:26

  4. Stefan Bürk commented on patch set 1 09/10/21, 17:50

    Sure it's a overwork, and I assume that ther is no seperated rendering for 11.4. But should it not be contained in the 11.4 branch also ? So add 11.4 ? Or would this be done anyway without it ?
  5. Oliver Klee commented on patch set 1 09/10/21, 17:55

    Reply

    As far as I can see, there is no 11.4 branch. And as far as I'm awaree, the "Releases" section in the commit message should only reference master or one of the LTS releases branches for backports.
  6. Stefan Bürk commented on patch set 1 CR +1 09/10/21, 22:36

    Reply

    Sry, though was created as 11.3 has one. Not looked before. So done
  7. Helmut Hummel voted on patch set 1 V +2 CR +2 09/11/21, 07:56

  8. Helmut Hummel commented on patch set 1 09/11/21, 07:56

    Thanls
  9. Helmut Hummel merged patch set 2 09/11/21, 07:57

  10. Mathias Brodala commented on patch set 2 09/13/21, 06:44

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:78

    The missing newline here will lead to this block not being rendered at all. I'll push a fix.
  11. Oliver Klee commented on patch set 2 09/17/21, 21:06

    Feature-94996-ConsiderAllComposerInstalledExtensionsAsActive.rst:78 Reply

    Ack