Review main Merged

71028[BUGFIX] Do not add 'offlineMode' setting in extbase by default

Torben Hansen CR +2 V +2 Easy +3 −6 updated 09/11/21, 13:08

Commit message

Since #94057, ['offlineMode' => false] is added to the settings array
in ActionController by default. This has most likely been added by
mistake, since it is not used in extbase but in ext:extensionmanager.

This patch removes the default 'offlineMode' setting in extbase and
ensures, it is always defined in ext:extensionmanager.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 711

  1. Torben Hansen uploaded patch set 1 09/11/21, 11:14

  2. core-ci voted on patch set 1 V -1 09/11/21, 11:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16538

  3. Torben Hansen uploaded patch set 2 09/11/21, 12:12

  4. core-ci voted on patch set 2 V +1 09/11/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16545

  5. Torben Hansen updated the commit message in patch set 3 09/11/21, 12:27

  6. core-ci voted on patch set 3 V +1 09/11/21, 12:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16548

  7. Christian Kuhn updated the commit message in patch set 4 09/11/21, 12:53

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 09/11/21, 12:55

  9. core-ci voted on patch set 4 V +1 09/11/21, 13:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16554

  10. Anja Leichsenring voted on patch set 4 V +2 CR +2 09/11/21, 13:08

  11. Anja Leichsenring merged patch set 5 09/11/21, 13:08