Review main Merged

71029[FOLLOWUP] Simplify Composer extension test setups

Helmut Hummel CR +2 V +2 Normal +89 −46 updated 09/13/21, 07:04

Commit message

The root package is now always considered as TYPO3 package.
The "ignore-as-root" flag and the exclusion of root packages
in general was only introduced to allow integration testing
setups of extensions with public resources.

For such a scenario to work properly, the testing framework
introduced \TYPO3\TestingFramework\Composer\ExtensionTestEnvironment
to be included as composer autoload hook, which symlinks
the root path inside the typo3conf/ext folder.

This exact behaviour is now introduced in TYPO3 directly,
making it possible to always consider the root package for TYPO3,
and obsoleting the double negative "ignore-as-root" flag.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jonas Eberle +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Files 3

Review log 1319

  1. Helmut Hummel uploaded patch set 1 09/11/21, 11:42

  2. core-ci voted on patch set 1 V -1 09/11/21, 12:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16544

  3. Helmut Hummel updated the commit message in patch set 2 09/11/21, 12:18

  4. Simon Schaufelberger commented on patch set 2 09/11/21, 12:29

    PackageArtifactBuilder.php:178

    one "already" too much
  5. core-ci voted on patch set 2 V -1 09/11/21, 12:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16546

  6. Helmut Hummel uploaded patch set 3 09/11/21, 12:36

  7. Helmut Hummel uploaded patch set 4 09/11/21, 12:38

  8. Helmut Hummel commented on patch set 3 09/11/21, 12:38

    PackageArtifactBuilder.php:178 Reply

    Ack
  9. core-ci voted on patch set 4 V +1 09/11/21, 12:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16552

  10. core-ci voted on patch set 3 V +1 09/11/21, 12:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16551

  11. Helmut Hummel uploaded patch set 5 09/11/21, 14:17

  12. core-ci voted on patch set 5 V +1 09/11/21, 14:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16565

  13. Christian Kuhn rebased onto patch set 6 09/11/21, 15:11

  14. core-ci voted on patch set 6 V +1 09/11/21, 15:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16567

  15. Christian Kuhn voted on patch set 6 V +1 CR +1 09/12/21, 06:20

  16. Jonas Eberle voted on patch set 6 V +1 09/12/21, 14:28

  17. Stefan Bürk commented on patch set 6 V +1 CR +1 09/12/21, 14:50

    Not as a blocker, just a little side thinking. Instead of just checking/doing this when "extra->typo3/cms" exists in the root composer.json, why not enforcing it on "extra->typo3/cms->extension-key" ?
  18. Andreas Kienast voted on patch set 6 V +2 CR +2 09/13/21, 07:04

  19. Andreas Kienast merged patch set 7 09/13/21, 07:04