Review main Merged

71033[TASK] gitlab-ci: Activate check permissions script

Christian Kuhn CR +2 V +2 Easy +6 −8 updated 09/12/21, 09:30

Commit message

Since moving to gitlab, script checkFilePermissions.sh
was inactive due to a gitlab detail that leads to
funny permissions of cloned files.

This can be suppressed with a gitlab feature toggle.

The patch activates that toggle, activates the test
script and fixes a couple of files that slipped in
with broken permissions meanwhile.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1321

  1. Christian Kuhn uploaded patch set 1 09/12/21, 06:43

  2. core-ci voted on patch set 1 V +1 09/12/21, 06:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16588

  3. Christian Kuhn uploaded patch set 2 09/12/21, 06:45

  4. core-ci voted on patch set 2 V +1 09/12/21, 06:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16589

  5. Christian Kuhn uploaded patch set 3 09/12/21, 06:48

  6. core-ci voted on patch set 3 V +1 09/12/21, 06:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16590

  7. Christian Kuhn uploaded patch set 4 09/12/21, 06:52

  8. core-ci voted on patch set 4 V -1 09/12/21, 06:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16591

  9. Christian Kuhn uploaded patch set 5 09/12/21, 07:29

  10. Christian Kuhn uploaded patch set 6 09/12/21, 07:32

  11. core-ci voted on patch set 5 V -1 09/12/21, 07:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16592

  12. core-ci voted on patch set 6 V +1 09/12/21, 07:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16593

  13. Christian Kuhn uploaded patch set 7 09/12/21, 07:37

  14. Christian Kuhn uploaded patch set 8 09/12/21, 07:59

  15. core-ci voted on patch set 8 V +1 09/12/21, 08:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16596

  16. Christian Kuhn uploaded patch set 9 09/12/21, 08:32

  17. core-ci voted on patch set 9 V +1 09/12/21, 08:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16597

  18. Wouter Wolters voted on patch set 9 V +1 CR +1 09/12/21, 09:24

  19. Anja Leichsenring voted on patch set 9 V +1 CR +1 09/12/21, 09:25

  20. Christian Kuhn commented on patch set 9 V +2 CR +2 09/12/21, 09:29

    thx for quick reviews. i'll merge this and can add the other gitlab runners again.
  21. Christian Kuhn merged patch set 10 09/12/21, 09:30