Review main Merged

71038[TASK] Delete acceptance split job files before recreation

Anja Leichsenring CR +2 V +2 Easy +10 −1 updated 09/13/21, 14:26

Commit message

The files grow ever larger when repeatedly executing splitAcceptanceTests.php.
Deleting them before they are written for the current run resolves the
problem.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Anja Leichsenring uploaded patch set 1 09/12/21, 09:54

  2. Christian Kuhn rebased onto patch set 2 09/12/21, 09:58

  3. core-ci voted on patch set 2 V +1 09/12/21, 10:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16604

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 09/12/21, 10:27

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 09/12/21, 10:32

  6. Stefan Bürk commented on patch set 2 V +1 CR +1 09/12/21, 14:44

    Nice, had seen this this night too, wanted to fix this after some sleep. Locally tested, files are now not growing larger and larger.
  7. Christian Kuhn commented on patch set 2 09/13/21, 08:14

    will take care as soon as gitlab access rights thingie is fixed ...
  8. Christian Kuhn voted on patch set 2 V +2 CR +2 09/13/21, 14:26

  9. Christian Kuhn merged patch set 3 09/13/21, 14:26