71040[TASK] Remove unnecessary assertions from tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 94
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/View/BackendLayoutViewTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+3 −15
- typo3/sysext/core/Tests/Unit/Cache/Backend/ApcuBackendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Command/SendEmailCommandTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+1 −2
- typo3/sysext/core/Tests/Unit/Core/ClassLoadingInformationGeneratorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Domain/Repository/PageRepositoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Imaging/ImageDimensionTest.php+3 −3
- typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/Processor/IntrospectionProcessorTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Package/PackageTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+1 −1
Show 74 more files
- typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/OnlineMedia/Helpers/VimeoHelperTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Processing/LocalPreviewHelperTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+12 −12
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Resource/Service/ExtractorServiceTest.php+23 −23
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/PlainTextExtractorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/TextExtractorRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/BaseTestCase.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+22 −22
- typo3/sysext/core/Tests/Unit/Service/FlexFormServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+14 −14
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+3 −3
- typo3/sysext/core/Tests/UnitDeprecated/Cache/Backend/PdoBackendTest.php+3 −3
- typo3/sysext/core/Tests/UnitDeprecated/Cache/Backend/WincacheBackendTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Configuration/BackendConfigurationManagerTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+3 −9
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+12 −12
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+9 −8
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+0 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/ConjunctionValidatorTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+3 −3
- typo3/sysext/extbase/Tests/UnitDeprecated/Configuration/AbstractConfigurationManagerTest.php+10 −10
- typo3/sysext/extbase/Tests/UnitDeprecated/Object/Container/ContainerTest.php+3 −3
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+6 −7
- typo3/sysext/extensionmanager/Tests/Unit/Utility/ListUtilityTest.php+1 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.php+5 −4
- typo3/sysext/fluid/Tests/Unit/View/AbstractTemplateViewTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/View/TemplatePathsTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Controller/FormEditorControllerTest.php+0 −2
- typo3/sysext/form/Tests/Unit/Controller/FormFrontendControllerTest.php+0 −3
- typo3/sysext/form/Tests/Unit/Controller/FormManagerControllerTest.php+1 −6
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidatorTest.php+11 −11
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidatorTest.php+9 −9
- typo3/sysext/form/Tests/Unit/Domain/Configuration/ConfigurationServiceTest.php+9 −9
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+2 −2
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionValidationServiceTest.php+10 −10
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+0 −3
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/TypoScriptServiceTest.php+0 −2
- typo3/sysext/form/Tests/Unit/Mvc/Persistence/FormPersistenceManagerTest.php+0 −35
- typo3/sysext/form/Tests/Unit/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+4 −4
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+0 −18
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.php+52 −53
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/impexp/Tests/Functional/Export/PresetsTest.php+1 −1
Review log 711
-
Wouter Wolters uploaded patch set 1 09/12/21, 10:36
-
core-ci voted on patch set 1 V +1 09/12/21, 10:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16608
-
Wouter Wolters uploaded patch set 2 09/22/21, 17:40
-
core-ci voted on patch set 2 V -1 09/22/21, 18:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17066
-
Wouter Wolters uploaded patch set 3 09/22/21, 18:21
-
core-ci voted on patch set 3 V +1 09/22/21, 18:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17073
-
Wouter Wolters uploaded patch set 4 11/04/21, 16:07
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 11/04/21, 16:22
-
core-ci voted on patch set 4 V +1 11/04/21, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18908
-
Christian Kuhn voted on patch set 4 V +2 CR +2 11/04/21, 16:30
-
Christian Kuhn merged patch set 5 11/04/21, 16:31