Review main Merged

71041[TASK] Use direct method invocation instead of calling it static

Wouter Wolters CR +2 V +2 Easy +39 −11 updated 11/04/21, 16:11

Commit message

In the process, some tests calling tests (which is bad style) have
been disentangled by calling the code explicit, rather then calling
the test method.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1015

  1. Wouter Wolters uploaded patch set 1 09/12/21, 10:43

  2. core-ci voted on patch set 1 V -1 09/12/21, 10:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16609

  3. Wouter Wolters rebased onto patch set 2 09/12/21, 11:04

  4. core-ci voted on patch set 2 V -1 09/12/21, 11:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16611

  5. Christian Kuhn rebased onto patch set 3 11/04/21, 14:30

  6. core-ci voted on patch set 3 V -1 11/04/21, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18890

  7. Christian Kuhn commented on patch set 3 11/04/21, 15:09

    AbstractActionTestCase.php:179

    this does not works since localizeContent() is overridden in workspace tests again, using $this then uses the inherited method, while self:: uses "own implementation" ... it's kinda ugly that localizeContentWithHideAtCopy() uses localizeContent() here in the first place and it would be better to simply copy the 1 or 2 calls from localizeContent() into localizeContentWithHideAtCopy() directly.
  8. Anja Leichsenring uploaded patch set 4 11/04/21, 15:35

  9. Anja Leichsenring commented on patch set 4 11/04/21, 15:36

    AbstractActionTestCase.php:179 Reply

    Done
  10. Anja Leichsenring uploaded patch set 5 11/04/21, 15:41

  11. core-ci voted on patch set 4 V -1 11/04/21, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18899

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 11/04/21, 16:01

  13. core-ci voted on patch set 5 V +1 11/04/21, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18902

  14. Anja Leichsenring voted on patch set 5 V +2 CR +2 11/04/21, 16:10

  15. Anja Leichsenring merged patch set 6 11/04/21, 16:11