Review main Merged

71042[TASK] Replace misuse of parent keyword to $this

Wouter Wolters CR +2 V +2 Easy +9 −9 updated 09/15/21, 16:45

Commit message

The parent keyword is misused in some places and $this can be
used instead.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 912

  1. Wouter Wolters uploaded patch set 1 09/12/21, 11:02

  2. core-ci voted on patch set 1 V -1 09/12/21, 11:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16610

  3. Wouter Wolters rebased onto patch set 2 09/12/21, 11:18

  4. core-ci voted on patch set 2 V -1 09/12/21, 11:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16612

  5. Wouter Wolters rebased onto patch set 3 09/13/21, 12:16

  6. core-ci voted on patch set 3 V +1 09/13/21, 12:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16649

  7. Benni Mack voted on patch set 3 CR +1 09/13/21, 13:03

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 09/15/21, 13:31

  9. Jochen Roth voted on patch set 3 V +1 CR +1 09/15/21, 14:06

  10. Oliver Klee voted on patch set 3 CR +1 09/15/21, 14:58

  11. Georg Ringer voted on patch set 3 V +2 CR +2 09/15/21, 16:44

  12. Georg Ringer merged patch set 4 09/15/21, 16:45