71042[TASK] Replace misuse of parent keyword to $this
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Jochen Roth +1
- Oliver Klee +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Package/FailsafePackageManager.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php+1 −1
- typo3/sysext/form/Classes/Hooks/FormFileProvider.php+2 −2
- typo3/sysext/impexp/Classes/Controller/ExportController.php+1 −1
- typo3/sysext/impexp/Classes/Controller/ImportController.php+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Discard/ActionTest.php+2 −2
Review log 912
-
Wouter Wolters uploaded patch set 1 09/12/21, 11:02
-
core-ci voted on patch set 1 V -1 09/12/21, 11:13 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16610
-
Wouter Wolters rebased onto patch set 2 09/12/21, 11:18
-
core-ci voted on patch set 2 V -1 09/12/21, 11:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16612
-
Wouter Wolters rebased onto patch set 3 09/13/21, 12:16
-
core-ci voted on patch set 3 V +1 09/13/21, 12:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16649
-
Benni Mack voted on patch set 3 CR +1 09/13/21, 13:03
-
Christian Kuhn voted on patch set 3 V +1 CR +1 09/15/21, 13:31
-
Jochen Roth voted on patch set 3 V +1 CR +1 09/15/21, 14:06
-
Oliver Klee voted on patch set 3 CR +1 09/15/21, 14:58
-
Georg Ringer voted on patch set 3 V +2 CR +2 09/15/21, 16:44
-
Georg Ringer merged patch set 4 09/15/21, 16:45