Review main Abandoned

71043[TASK] Use GIT strategy clone for integration tests

Wouter Wolters CR 0 V 0 Easy +14 −0 updated 09/13/21, 11:35

Commit message

Gitlab FF_DISABLE_UMASK_FOR_DOCKER_EXECUTOR feature
has been set to reactivate the checkPermissions script
again, which is needed. Gitlab reacts here in a kindly
weired way in how it enforce clones in normal mode,
but use stale git repository clone if older patches
are checkout once. Thus we enforce full clone strategy
temporarily until most of the patches has been rebased
onto the patch activating the umask feature.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 710

  1. Wouter Wolters uploaded patch set 1 09/12/21, 12:06

  2. core-ci voted on patch set 1 V -1 09/12/21, 12:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16615

  3. Wouter Wolters uploaded patch set 2 09/12/21, 12:07

  4. core-ci voted on patch set 2 V +1 09/12/21, 12:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16616

  5. Stefan Bürk uploaded patch set 3 09/12/21, 14:40

  6. core-ci voted on patch set 3 V +1 09/12/21, 14:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16622

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 09/12/21, 16:35

  8. Christian Kuhn voted on patch set 3 V 0 CR 0 09/12/21, 16:36

  9. Christian Kuhn commented on patch set 3 09/13/21, 11:34

    We'll abandon this change since https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046 is a more elegant solution.
  10. Christian Kuhn abandoned the change 09/13/21, 11:35