71044[TASK] Reduce inline JavaScript of requireJS in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 41
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectSingleElement.ts+18 −3
- Build/Sources/TypeScript/rte_ckeditor/Resources/Public/TypeScript/FormEngineInitializer.tsnew+78 −0
- Build/types/TYPO3/index.d.ts+4 −0
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php+23 −11
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+4 −5
- typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php+2 −2
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+7 −8
- typo3/sysext/backend/Classes/Form/Container/SiteLanguageContainer.php+2 −1
- typo3/sysext/backend/Classes/Form/Container/TabsContainer.php+2 −1
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+6 −2
- typo3/sysext/backend/Classes/Form/Element/CategoryElement.php+2 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+4 −5
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+4 −3
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+4 −3
- typo3/sysext/backend/Classes/Form/Element/InputDateTimeElement.php+4 −5
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+5 −6
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+4 −5
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+5 −4
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php+4 −5
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+5 −6
Show 21 more files
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+4 −5
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+23 −15
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+5 −5
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+5 −6
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+5 −7
- typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php+2 −1
- typo3/sysext/backend/Classes/Form/FieldControl/EditPopup.php+2 −1
- typo3/sysext/backend/Classes/Form/FieldControl/InsertClipboard.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php+2 −1
- typo3/sysext/backend/Classes/Form/FieldControl/ListModule.php+2 −1
- typo3/sysext/backend/Classes/Form/FieldControl/ResetSelection.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/LocalizationStateSelector.php+4 −6
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+33 −11
- typo3/sysext/backend/Classes/Form/FormResultTrait.phpnew+62 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectSingleElement.js+1 −1
- typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php+5 −2
- typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php2new+129 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95200-DeprecateRequireJSCallbacksAsInlineJavaScript.rstnew+79 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+17 −55
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/FormEngineInitializer.jsnew+13 −0
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+2 −3
Review log 3551
Show 1826 earlier messages
-
Oliver Hader uploaded patch set 1 09/12/21, 14:09
-
core-ci voted on patch set 1 V -1 09/12/21, 14:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16619
-
Oliver Hader uploaded patch set 2 09/12/21, 14:54
-
core-ci voted on patch set 2 V -1 09/12/21, 15:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16623
-
Oliver Hader wrote 09/13/21, 16:09
Topic set to inline-javascript -
Oliver Hader updated the commit message in patch set 3 09/13/21, 16:24
-
core-ci voted on patch set 3 V -1 09/13/21, 16:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16663
-
Oliver Hader uploaded patch set 4 09/14/21, 08:46
-
core-ci voted on patch set 4 V -1 09/14/21, 09:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16688
-
Oliver Hader uploaded patch set 5 09/14/21, 09:47
-
Oliver Hader uploaded patch set 6 09/14/21, 09:50
-
Oliver Hader uploaded patch set 7 09/14/21, 09:53
-
Oliver Hader uploaded patch set 8 09/14/21, 10:07
-
core-ci voted on patch set 7 V -1 09/14/21, 10:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16695
-
core-ci voted on patch set 8 V +1 09/14/21, 10:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16696
-
Oliver Hader commented on patch set 8 CR -1 09/20/21, 08:52
On it... -
Oliver Hader voted on patch set 8 CR 0 09/20/21, 08:57
-
Oliver Hader rebased onto patch set 9 09/24/21, 08:06
-
Benni Mack commented on patch set 9 CR -1 09/24/21, 08:09
FormEngineUtility.ts:34this is a dependency of EXT:rte_ckeditor for EXT:backend -
Oliver Hader commented on patch set 9 09/24/21, 08:13
FormEngineUtility.ts:34ReplyOh, right... I'll move the new JavaScript initializer to ext:rte_ckeditor -
Oliver Hader uploaded patch set 10 09/24/21, 08:31
-
core-ci voted on patch set 9 V +1 09/24/21, 08:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17139
-
Benni Mack commented on patch set 10 09/24/21, 08:46
FormEngineUtility.ts:34ReplyAck -
core-ci voted on patch set 10 V +1 09/24/21, 08:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17141
-
Benni Mack voted on patch set 10 CR +1 09/24/21, 08:47
-
Oliver Hader uploaded patch set 11 09/24/21, 16:50
-
core-ci voted on patch set 11 V +1 09/24/21, 17:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17171
-
Benni Mack rebased onto patch set 12 09/30/21, 14:50
-
core-ci voted on patch set 12 V +1 09/30/21, 15:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17351
-
Nikita Hovratov uploaded patch set 13 10/01/21, 14:13
-
core-ci voted on patch set 13 V +1 10/01/21, 14:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17440
-
Nikita Hovratov commented on patch set 13 V -1 10/01/21, 14:30
RTE in inline is not working anymore. Styleguide > "elements rte" > "in inline" -
Oliver Hader commented on patch set 13 10/01/21, 14:57
Reply
What exactly is not working anymore? -
Nikita Hovratov commented on patch set 13 10/01/21, 15:03
Reply
The RTE field is not loaded. Try to open the inline container. There seems to be another (not related) JavaScript bug as well in the console. Will open another ticket for that. -
Oliver Hader commented on patch set 13 10/01/21, 15:16
`AbstractFormEngineAjaxController::createExecutableStringRepresentationOfRegisteredRequireJsModules` is missing... I don't have any idea yet how to solve that... -
Oliver Hader uploaded patch set 14 10/01/21, 16:32
-
Oliver Hader commented on patch set 14 10/01/21, 16:33
@Nikita, that was a very good catch. I'd be glad if you could test my recent update again and verify it (hopefully) works now. Thanks in advance! -
core-ci voted on patch set 14 V -1 10/01/21, 16:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17453
-
Nikita Hovratov uploaded patch set 15 10/01/21, 16:55
-
Nikita Hovratov commented on patch set 15 V +1 CR +1 10/01/21, 17:04
Reply
Thanks! Really like this patch. Looks good for me, everything works now. -
core-ci voted on patch set 15 V +1 10/01/21, 17:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17455
-
Benjamin Franzke uploaded patch set 16 10/01/21, 22:55
-
core-ci voted on patch set 16 V -1 10/01/21, 22:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17466
-
Benjamin Franzke uploaded patch set 17 10/01/21, 23:01
-
Oli Bartsch uploaded patch set 18 10/01/21, 23:04
-
Benjamin Franzke uploaded patch set 19 10/01/21, 23:09
-
Oli Bartsch commented on patch set 19 V +1 CR +1 10/01/21, 23:15
JavaScriptModuleInstruction.php:22Maybe we could add a bit of description for this new class. -
core-ci voted on patch set 17 V +1 10/01/21, 23:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17467
-
core-ci voted on patch set 19 V +1 10/01/21, 23:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17469
-
Benjamin Franzke commented on patch set 19 V +2 CR +2 10/01/21, 23:35
JavaScriptModuleInstruction.php:22ReplyMaybe: DTO for a defined set of JavaScript instruction opcodes that can be attached to JavaScript modules. But as you already said via slack, olly can add that afterwards as well. -
Benjamin Franzke merged patch set 20 10/01/21, 23:36