71045[BUGFIX] Fix various "undefined array key" warnings in PageRenderer
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 67
-
Robert Kärner uploaded patch set 1 09/12/21, 15:36
-
core-ci voted on patch set 1 V -1 09/12/21, 15:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16624
-
Jochen Roth commented on patch set 1 09/12/21, 17:21
See this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70867 Which make the RequestHandler php8 compatible. -
Robert Kärner commented on patch set 1 09/12/21, 19:15
Reply
Thanks for showing me. I can see that patch 70867 doesn‘t fix all occurrences in RequestHandler, i.e. at includeCSSLibs. Should I create a new patchset with my changes on 70867 and we close this one? -
Jochen Roth commented on patch set 1 09/12/21, 19:36
Reply
I would suggest to close this one and add your changes to https://review.typo3.org/c/Packages/TYPO3.CMS/+/70867 -
Robert Kärner commented on patch set 1 09/12/21, 20:33
Reply
Will do … tomorrow :) Thanks for your support! -
Robert Kärner abandoned the change 09/12/21, 20:34
Duplicate of patch 70867