Review main Merged

71046[TASK] Better checks in Build/Script/checkFilePermissions.sh

Jonas Eberle CR +2 V +2 Easy +2 −1 updated 09/13/21, 12:07

Commit message

git stores files either 0664 or 0775. Script
checkFilePermissions.sh is improved to deal with that.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jonas Eberle +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jonas Eberle +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1519

  1. Jonas Eberle uploaded patch set 1 09/12/21, 16:05

  2. Stefan Bürk commented on patch set 1 09/12/21, 16:15

    checkFilePermissions.sh:19

    May you add a one/two liner comment stating shortly why only checking for u+x here is more then enough ? I'm understanding it, but maybe some looks in here and want to change it and should now that it does not make sense.
  3. core-ci voted on patch set 1 V +1 09/12/21, 16:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16626

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 09/12/21, 16:22

  5. Jonas Eberle commented on patch set 1 09/12/21, 16:28

    checkFilePermissions.sh:19 Reply

    I agree. All the scripts need some general love. I can do that in a follow up.
  6. Christian Kuhn commented on patch set 1 09/13/21, 08:06

    checkFilePermissions.sh:19 Reply

    I think we should at least check neither user, nor group nor others have x flag set, and we also may want a 0 as 'special' flag.
  7. Christian Kuhn commented on patch set 1 CR -1 09/13/21, 08:15

    i'll play around a bit. will take care asap to reach green builds again.
  8. Christian Kuhn uploaded patch set 2 09/13/21, 11:29

  9. Christian Kuhn commented on patch set 2 CR -1 09/13/21, 11:30

    this should go read due to foo1.txt being executable.
  10. Christian Kuhn updated the commit message in patch set 3 09/13/21, 11:33

  11. Christian Kuhn uploaded patch set 4 09/13/21, 11:33

  12. core-ci voted on patch set 3 V -1 09/13/21, 11:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16642

  13. core-ci voted on patch set 2 V -1 09/13/21, 11:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16641

  14. core-ci voted on patch set 4 V +1 09/13/21, 11:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16643

  15. Jonas Eberle voted on patch set 4 V +1 CR +1 09/13/21, 11:51

  16. Stefan Bürk voted on patch set 4 V +1 CR +1 09/13/21, 11:56

  17. Christian Kuhn commented on patch set 4 09/13/21, 12:06

    i'll go ahead and merge it to greenify builds again ...
  18. Christian Kuhn voted on patch set 4 V +2 CR +2 09/13/21, 12:06

  19. Christian Kuhn merged patch set 5 09/13/21, 12:07