71046[TASK] Better checks in Build/Script/checkFilePermissions.sh
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jonas Eberle +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jonas Eberle +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1519
-
Jonas Eberle uploaded patch set 1 09/12/21, 16:05
-
Stefan Bürk commented on patch set 1 09/12/21, 16:15
-
core-ci voted on patch set 1 V +1 09/12/21, 16:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16626
-
Stefan Bürk voted on patch set 1 V +1 CR +1 09/12/21, 16:22
-
Jonas Eberle commented on patch set 1 09/12/21, 16:28
checkFilePermissions.sh:19ReplyI agree. All the scripts need some general love. I can do that in a follow up. -
Christian Kuhn commented on patch set 1 09/13/21, 08:06
checkFilePermissions.sh:19ReplyI think we should at least check neither user, nor group nor others have x flag set, and we also may want a 0 as 'special' flag. -
Christian Kuhn commented on patch set 1 CR -1 09/13/21, 08:15
i'll play around a bit. will take care asap to reach green builds again. -
Christian Kuhn uploaded patch set 2 09/13/21, 11:29
-
Christian Kuhn commented on patch set 2 CR -1 09/13/21, 11:30
this should go read due to foo1.txt being executable. -
Christian Kuhn updated the commit message in patch set 3 09/13/21, 11:33
-
Christian Kuhn uploaded patch set 4 09/13/21, 11:33
-
core-ci voted on patch set 3 V -1 09/13/21, 11:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16642
-
core-ci voted on patch set 2 V -1 09/13/21, 11:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16641
-
core-ci voted on patch set 4 V +1 09/13/21, 11:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16643
-
Jonas Eberle voted on patch set 4 V +1 CR +1 09/13/21, 11:51
-
Stefan Bürk voted on patch set 4 V +1 CR +1 09/13/21, 11:56
-
Christian Kuhn commented on patch set 4 09/13/21, 12:06
i'll go ahead and merge it to greenify builds again ... -
Christian Kuhn voted on patch set 4 V +2 CR +2 09/13/21, 12:06
-
Christian Kuhn merged patch set 5 09/13/21, 12:07
checkFilePermissions.sh:19