Review 10.4 Merged

71048[BUGFIX] Correct decision about new content button

Claus Due CR +2 V +2 Easy +9 −6 updated 09/17/21, 06:04

Commit message

This patch fixes an issue with mod.web_layout.defLangBinding = 1
which when enabled would cause the page layout module to
render the "new content" buttons when this was not desired.

The fixes consist of:

* A change to make sure that Fluid variable {column} contains
  the right language ID in the PageLayoutContext associated
  with the column; by re-assigning {column} within the loop
  over {languageColumns} in LanguageColumns.html
* Re-overwriting the {column} variable after the loop to ensure
  it holds the default language column which holds the default
  language column's content records that are iterated over.
* Overwriting the {column} variable within the loop that renders
  each content record to ensure it holds the correct language ID
  in the column's PageLayoutContext.
* Assigning the right PageLayoutContext to translated versions
  of content records to ensure that the "new content" button
  below each translated content element points to the right
  language UID.
* A visual alignment fix setting valign="top" on TD elements
  to ensure the alignment of each content record and the
  column header, when the "new content" button is not shown.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Alexander Opitz +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Alexander Opitz +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Claus Due uploaded patch set 1 09/13/21, 07:55

  2. Claus Due commented on patch set 1 09/13/21, 07:56

  3. core-ci voted on patch set 1 V +1 09/13/21, 08:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16636

  4. Alexander Opitz voted on patch set 1 V +1 CR +1 09/13/21, 12:50

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/17/21, 06:03

  6. Anja Leichsenring merged patch set 2 09/17/21, 06:04