Review main Merged

71050[BUGFIX] Evaluate edit permissions of live search suggestions

Oli Bartsch CR +2 V +2 Normal +46 −22 updated 09/15/21, 08:39

Commit message

The edit permissions for linked live search suggestions,
shown in the the dropdown layer, were previously not
properly evaluated.

This is now fixed. In case a user does have insufficient
edit permissions for a live search suggestion, it won't
be linked anymore.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 89

  1. Oli Bartsch uploaded patch set 1 09/13/21, 10:10

  2. core-ci voted on patch set 1 V +1 09/13/21, 10:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16639

  3. Wouter Wolters voted on patch set 1 CR +1 09/13/21, 17:52

  4. Benni Mack commented on patch set 1 09/14/21, 09:45

    LiveSearch.ts:19

    we don't use lit in v10. backport will be difficult
  5. Oli Bartsch commented on patch set 1 09/14/21, 14:15

    LiveSearch.ts:19 Reply

    Not that difficult, since only string concatenation is done there. Already pushed the backport: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71082
  6. Benni Mack voted on patch set 1 V +1 CR +1 09/14/21, 19:16

  7. Jochen Roth voted on patch set 1 V +1 CR +1 09/15/21, 07:24

  8. Oli Bartsch voted on patch set 1 V +2 CR +2 09/15/21, 08:39

  9. Oli Bartsch merged patch set 2 09/15/21, 08:39