Review 9.5 Merged

71062[BUGFIX] Bump symfony/polyfill-mbstring to ^1.16

Benni Mack CR +2 V +2 Easy +16 −11 updated 09/20/21, 15:21

Commit message

ext:frontend uses the function mb_ord which is available since
symfony/polyfill-mbstring v1.16 and to avoid issue this dependency is
properly increased and also added to ext:frontend.

Composer commands used:
* composer require "symfony/polyfill-mbstring:^1.16"
* composer require --no-update -d typo3/sysext/core "symfony/polyfill-mbstring:^1.16"
* composer require --no-update -d typo3/sysext/frontend "symfony/polyfill-mbstring:^1.16"

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Benni Mack commented on patch set 1 09/20/21, 15:05

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/core/composer.json * typo3/sysext/frontend/composer.json
  2. core-ci voted on patch set 1 V -1 09/20/21, 15:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16944

  3. Benni Mack uploaded patch set 2 09/20/21, 15:11

  4. Benni Mack marked it ready for review 09/20/21, 15:12

  5. core-ci voted on patch set 2 V +1 09/20/21, 15:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16946

  6. Benni Mack voted on patch set 2 V +2 CR +2 09/20/21, 15:21

  7. Benni Mack merged patch set 3 09/20/21, 15:21