71072[TASK] Deprecate and replace onchange & onclick attrs in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Jonas Eberle +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 33
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTreeElement.ts+14 −2
- Build/types/TYPO3/index.d.ts+7 −0
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+8 −8
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php+33 −12
- typo3/sysext/backend/Classes/Form/Behavior/OnFieldChangeInterface.phpnew+34 −0
- typo3/sysext/backend/Classes/Form/Behavior/OnFieldChangeTrait.phpnew+111 −0
- typo3/sysext/backend/Classes/Form/Behavior/ReloadOnFieldChange.phpnew+67 −0
- typo3/sysext/backend/Classes/Form/Behavior/UpdateBitmaskOnFieldChange.phpnew+75 −0
- typo3/sysext/backend/Classes/Form/Behavior/UpdateValueOnFieldChange.phpnew+77 −0
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+11 −18
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+8 −6
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php2+23 −17
- typo3/sysext/backend/Classes/Form/Element/CheckboxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/CheckboxLabeledToggleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/CheckboxToggleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+14 −6
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+9 −4
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+9 −4
- typo3/sysext/backend/Classes/Form/Element/RadioElement.php2+18 −10
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+23 −9
Show 13 more files
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+15 −9
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+13 −8
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+30 −12
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+20 −13
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+15 −10
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php2+7 −1
- typo3/sysext/backend/Classes/Form/FieldControl/EditPopup.php+8 −7
- typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php+8 −7
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+65 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineLinkBrowserAdapter.js+6 −3
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-91787-DeprecateInlineJavaScriptInFieldChangeFunc.rst2new+152 −0
- phpstan.neon+0 −4
Review log 2333
Show 58 earlier messages
-
Oliver Hader uploaded patch set 1 09/13/21, 12:52
-
core-ci voted on patch set 1 V +1 09/13/21, 13:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16652
-
Oliver Hader uploaded patch set 2 09/13/21, 16:08
-
Oliver Hader wrote 09/13/21, 16:09
Topic set to inline-javascript -
core-ci voted on patch set 2 V +1 09/13/21, 16:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16661
-
Oliver Hader uploaded patch set 3 09/13/21, 16:24
-
Oliver Hader uploaded patch set 4 09/13/21, 16:34
-
core-ci voted on patch set 3 V +1 09/13/21, 16:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16662
-
core-ci voted on patch set 4 V +1 09/13/21, 16:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16664
-
Oliver Hader uploaded patch set 5 09/13/21, 20:55
-
Oliver Hader uploaded patch set 6 09/13/21, 21:01
-
core-ci voted on patch set 5 V +1 09/13/21, 21:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16678
-
core-ci voted on patch set 6 V +1 09/13/21, 21:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16679
-
Oliver Hader uploaded patch set 7 09/14/21, 07:58
-
core-ci voted on patch set 7 V +1 09/14/21, 08:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16687
-
Oliver Hader rebased onto patch set 8 09/14/21, 09:14
-
core-ci voted on patch set 8 V +1 09/14/21, 09:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16691
-
Benni Mack voted on patch set 8 V +1 CR +1 09/23/21, 08:41
-
Oli Bartsch commented on patch set 8 V -1 09/23/21, 11:28
Can no longer check "toggle checkboxes", e.g. `pages.no_follow`. -
Oliver Hader commented on patch set 8 09/23/21, 11:51
AbstractFormElement.php:348logical mistake here.. -
Oliver Hader uploaded patch set 9 09/23/21, 12:50
-
Oliver Hader commented on patch set 9 09/23/21, 12:51
AbstractFormElement.php:348ReplyDone -
core-ci voted on patch set 9 V +1 09/23/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17102
-
Benni Mack voted on patch set 9 V +1 CR +1 09/23/21, 16:24
-
Oli Bartsch commented on patch set 9 09/23/21, 17:27
RadioElement.php:93Now unusedUserSysFileStorageIsPublicElement.php:99This variable seems to be undefinedDeprecation-91787-DeprecateInlineJavaScriptInFieldChangeFunc.rst:17of -
Oli Bartsch uploaded patch set 10 09/23/21, 17:28
-
Oli Bartsch commented on patch set 10 V +1 CR +1 09/23/21, 17:28
RadioElement.php:93ReplyDoneUserSysFileStorageIsPublicElement.php:99ReplyDoneDeprecation-91787-DeprecateInlineJavaScriptInFieldChangeFunc.rst:17ReplyDone -
core-ci voted on patch set 10 V +1 09/23/21, 17:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17115
-
Jonas Eberle commented on patch set 10 V +1 09/23/21, 19:46
I tested custom elements with the provided extension, linkhandler, checkboxes, displayCond. I watched for onclick/onfocus in the DOM (and found some in ckeditor...). I realized that with backward-compatibility we can't deliver a strict CSP by default yet. But this is great stuff! Thank you! -
Benni Mack voted on patch set 10 V +1 CR +1 09/24/21, 06:11
-
Oliver Hader commented on patch set 10 V +2 CR +2 09/24/21, 07:56
Thx for the reviews and changes, folks! -
Oliver Hader merged patch set 11 09/24/21, 07:56
-
Oliver Hader commented on patch set 11 09/24/21, 08:02
Reply
Thx for the feedback. I would have loved to remove these inline scripts directly, but of course users also must have the chance to migrate their code to use the new declarations. In case you identify more inline scripts in the backend area, feel free to create a new sub-task at https://forge.typo3.org/issues/87418.