Review main Merged

71075[BUGFIX] Mitigate thread unsafe usage of getenv

Helmut Hummel CR +2 V +2 Easy +14 −5 updated 09/13/21, 21:15

Commit message

Drop usage of getenv('TYPO3_PATH_COMPOSER_ROOT') and use
Composer provided runtime API to determine the path of the
root package.

This mitigates thread unsafety at least for packages, which
is more prevalent than other getenv usages, that exist in TYPO3
already. These should be tackled in subsequent changes.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Helmut Hummel uploaded patch set 1 09/13/21, 16:49

  2. core-ci voted on patch set 1 V +1 09/13/21, 17:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16665

  3. Helmut Hummel updated the commit message in patch set 2 09/13/21, 17:03

  4. Benjamin Franzke voted on patch set 2 V +1 CR +1 09/13/21, 17:13

  5. core-ci voted on patch set 2 V +1 09/13/21, 17:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16668

  6. Wouter Wolters voted on patch set 2 CR +1 09/13/21, 17:56

  7. Georg Ringer voted on patch set 2 V +2 CR +2 09/13/21, 18:09

  8. Georg Ringer merged patch set 3 09/13/21, 18:09

  9. Helmut Hummel commented on patch set 3 09/13/21, 18:36

    Thanks for the swift merge!
  10. Oliver Hader voted on patch set 3 CR +1 09/13/21, 21:15