Review main Merged

71077[TASK] Only show pagination on bottom

Sybille Peters CR +2 V +2 Easy +0 −2 updated 09/15/21, 04:43

Commit message

Previously, the pagination controls were sometimes shown
on the bottom of the page and sometimes on the top
and the bottom (e.g. EXT:form, EXT:redirect).

The pagination controls are now only shown on the bottom.
This adds more consistency to the user interface.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jonas Eberle +1
    • Rachel Foucard +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jonas Eberle +1
    • Rachel Foucard +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Sybille Peters uploaded patch set 1 09/13/21, 17:21

  2. core-ci voted on patch set 1 V +1 09/13/21, 17:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16670

  3. Sybille Peters updated the commit message in patch set 2 09/13/21, 17:47

  4. core-ci voted on patch set 2 V +1 09/13/21, 18:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16672

  5. Oli Bartsch commented on patch set 2 09/13/21, 18:33

    I don't see the reason for using a "top" pagination. Usually one would scroll through a list and at the end, go to the next page. This is also the case for workspaces and recycler pagination. If changing this at all, we should IMO always use "bottom" pagination.
  6. Sybille Peters commented on patch set 2 09/14/21, 07:09

    Reply

    If you want to quickly paginate through a list several times you have to scroll down every time to go to the next page (especially for pages with many records, such as redirects). For example, if you have many BE groups, this can be very annoying. However, I find it more important that you have good filter / search / sort options. You don't really need the pagination then, if the results you look for are on top. In that case, it would be better on the bottom. So, I will change it. We probably should add a filter for BE groups then.
  7. Sybille Peters uploaded patch set 3 09/14/21, 07:25

  8. core-ci voted on patch set 3 V +1 09/14/21, 07:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16684

  9. Georg Ringer voted on patch set 3 V +1 CR +1 09/14/21, 14:14

  10. Rachel Foucard voted on patch set 3 V +1 CR +1 09/14/21, 14:40

  11. Jonas Eberle voted on patch set 3 V +1 CR +1 09/14/21, 20:14

  12. Georg Ringer voted on patch set 3 V +2 CR +2 09/15/21, 04:43

  13. Georg Ringer merged patch set 4 09/15/21, 04:43