Review main Abandoned

71081[BUGFIX] Allow switching table controls

Oli Bartsch CR 0 V 0 Normal +99 −6 updated 09/15/21, 16:12

Commit message

The new multi record selection, added to the
recordlist in #95068 allows to perform multiple
actions for a selection of records.

In case a selection is transferred to a numeric
clipboard, the selection is kept, when reloading
the module or switching to the single table view.

However, latter was no longer possible, because
as soon as one record got selected, the multi
record selection actions were displayed in the
table header and the module specific actions,
such as switching to single table view or the
column selector, were hidden.

This is now resolved by adding a new toggle
button to the table header, as soon as a record
is selected. It can therefore be used to switch
between the multi record selection actions and
the module related ones, e.g. the link to the
single table view.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 9

Review log 57

  1. Oli Bartsch uploaded patch set 1 09/14/21, 13:21

  2. Oli Bartsch uploaded patch set 2 09/14/21, 13:25

  3. core-ci voted on patch set 1 V +1 09/14/21, 13:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16700

  4. core-ci voted on patch set 2 V +1 09/14/21, 13:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16701

  5. Jochen Roth voted on patch set 2 V +1 CR +1 09/15/21, 07:01

  6. Oli Bartsch commented on patch set 2 CR -2 09/15/21, 12:53

    Will come up with a different solution
  7. Oli Bartsch abandoned the change 09/15/21, 16:12

    The problem with the hidden module actions is resolved in #95225. The feature request for "keeping selection on switching to single table view" might be added in v12.