Review main Merged

71083[BUGFIX] Restrict composer-runtime-api to 2.1

Helmut Hummel CR +2 V +2 Normal +43 −14 updated 09/16/21, 13:18

Commit message

With https://review.typo3.org/c/Packages/TYPO3.CMS/+/71075
usage of InstalledVersions class was introduced.
More specifically the install_path of the root package.

However install paths of packages are only available
in composer-runtime-api 2.1, therefore we need to
require this a minimum version.

As drive by change the usage of Composer runtime API
is encapsulated in the Environment class and
path normalisation is put there as well, to not require
normalisation for each package.

composer req composer-runtime-api:^2.1
composer req composer-runtime-api:^2.1 -d typo3/sysext/core/ --no-update

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 811

  1. Helmut Hummel uploaded patch set 1 09/14/21, 15:06

  2. core-ci voted on patch set 1 V -1 09/14/21, 15:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16712

  3. Helmut Hummel uploaded patch set 2 09/16/21, 05:40

  4. core-ci voted on patch set 2 V +1 09/16/21, 05:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16774

  5. Benjamin Franzke commented on patch set 2 09/16/21, 06:09

    I think we need a new issue number here.
  6. Helmut Hummel updated the commit message in patch set 3 09/16/21, 06:34

  7. Helmut Hummel commented on patch set 3 09/16/21, 06:35

    Reply

    Done
  8. core-ci voted on patch set 3 V +1 09/16/21, 06:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16775

  9. Benni Mack voted on patch set 3 V +1 CR +1 09/16/21, 13:08

  10. Andreas Kienast commented on patch set 3 V +2 CR +2 09/16/21, 13:18

    Confirmed, we ran into issues with Composer 2.0
  11. Andreas Kienast merged patch set 4 09/16/21, 13:18