71087[BUGFIX] Initialize selected crop variant on modal open
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/Sass/component/_modal.scss6+37 −4
- Build/Sources/Sass/typo3/_element_cropper.scss2+13 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ImageManipulation.ts8+5 −21
- typo3/sysext/backend/Resources/Private/Templates/ImageManipulation/ImageManipulationWizard.html1+5 −4
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ImageManipulation.js+1 −1
Review log 2340
Show 915 earlier messages
-
Jochen Roth uploaded patch set 1 09/14/21, 19:51
-
core-ci voted on patch set 1 V +1 09/14/21, 20:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16719
-
Jochen Roth uploaded patch set 2 09/16/21, 09:32
-
core-ci voted on patch set 2 V +1 09/16/21, 09:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16782
-
Jochen Roth uploaded patch set 3 09/16/21, 15:05
-
core-ci voted on patch set 3 V -1 09/16/21, 15:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16809
-
Jochen Roth uploaded patch set 4 09/17/21, 13:06
-
core-ci voted on patch set 4 V -1 09/17/21, 14:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16876
-
Jochen Roth uploaded patch set 5 09/17/21, 15:12
-
core-ci voted on patch set 5 V +1 09/17/21, 15:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16884
-
Jochen Roth uploaded patch set 6 10/04/21, 09:10
-
Oli Bartsch commented on patch set 6 10/04/21, 09:26
method_modal.scss:154Where is this value from?_modal.scss:158Where is this value from?_modal.scss:190Should be handled in modal configuration_element_cropper.scss:1let's use &.cropper in the body (IMO easier to read)ImageManipulation.ts:183Could you explain this a bit? I'm just curious why we have to wait while we already use a callback.ImageManipulation.ts:241Shouldn't this happen automatically?ImageManipulation.ts:250AFAIK, this can be handled in modal configuration.ImageManipulation.ts:261Can those lines be removed then?ImageManipulationWizard.html:40Good catch! -
core-ci voted on patch set 6 V +1 10/04/21, 09:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17539
-
Jochen Roth uploaded patch set 7 10/04/21, 13:13
-
Jochen Roth commented on patch set 7 10/04/21, 13:20
Thanks for your feedback. :-)Reply
Done_modal.scss:154Reply UnresolvedThis is the width of the sidebar panel._modal.scss:158Reply UnresolvedThis is the width of the sidebar panel._modal.scss:190Reply UnresolvedThis is the sidebar accordion for the cropping variants. One always needs to be open. This is hardcorded in bootstraps accordion. Therefore the pointer events have been disabled._element_cropper.scss:1ReplyDoneImageManipulation.ts:183Reply UnresolvedThanks, helped me to find a better position for this chunk of code. Now triggering `this.update()` within `this.init()` method to be sure the cropper is initialized correctly. It was meant to wait for `this.init()`, which was not a good idea at all.ImageManipulation.ts:241Reply UnresolvedNope not in this case. This is basically just the "image loading spinner" for the image to be cropped and not the ajax content loading spinner. That's why i have to remove it here.ImageManipulation.ts:250Reply UnresolvedThere is currently not option in Modal.ts to do so. Leaving it as is for now.ImageManipulation.ts:261ReplyDone
-
Jochen Roth updated the commit message in patch set 8 10/04/21, 13:20
-
core-ci voted on patch set 7 V +1 10/04/21, 13:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17556
-
core-ci voted on patch set 8 V +1 10/04/21, 13:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17557
-
Nikita Hovratov voted on patch set 8 V +1 10/04/21, 13:55
-
Jochen Roth uploaded patch set 9 11/04/21, 10:09
-
Jochen Roth uploaded patch set 10 11/04/21, 10:14
-
core-ci voted on patch set 9 V +1 11/04/21, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18855
-
core-ci voted on patch set 10 V +1 11/04/21, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18856
-
Jochen Roth uploaded patch set 11 11/04/21, 12:29
-
core-ci voted on patch set 11 V -1 11/04/21, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18877
-
Jochen Roth rebased onto patch set 12 11/04/21, 13:51
-
core-ci voted on patch set 12 V +1 11/04/21, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18886
-
Anja Leichsenring updated the commit message in patch set 13 11/04/21, 14:49
-
Anja Leichsenring voted on patch set 13 V +1 CR +1 11/04/21, 14:55
-
core-ci voted on patch set 13 V +1 11/04/21, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18894
-
Jochen Roth uploaded patch set 14 11/04/21, 16:56
-
core-ci voted on patch set 14 V -1 11/04/21, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18914
-
core-ci commented on patch set 14 11/05/21, 07:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18914
-
Anja Leichsenring rebased onto patch set 15 11/05/21, 07:21
-
core-ci voted on patch set 15 V -1 11/05/21, 07:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18922
-
Jochen Roth uploaded patch set 16 11/05/21, 09:36
-
core-ci voted on patch set 16 V +1 11/05/21, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18934
-
Anja Leichsenring voted on patch set 16 V +1 CR +1 11/05/21, 10:03
-
Andreas Kienast voted on patch set 16 V +2 CR +2 11/05/21, 10:11
-
Andreas Kienast merged patch set 17 11/05/21, 10:11