Review main Merged

71087[BUGFIX] Initialize selected crop variant on modal open

Jochen Roth CR +2 V +2 Normal +62 −35 updated 11/05/21, 10:11

Commit message

In the cropper modal the initial aspect ratio
is not respected.

This has been fixed by triggering the update method
when the cropper modal is initialized.

Also by using CropperJs' built-in responsive feature
we avoid tinkering with pixel sizes when window is
resized and optimize ui to be more responsive.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2340

Show 915 earlier messages
  1. Jochen Roth uploaded patch set 1 09/14/21, 19:51

  2. core-ci voted on patch set 1 V +1 09/14/21, 20:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16719

  3. Jochen Roth uploaded patch set 2 09/16/21, 09:32

  4. core-ci voted on patch set 2 V +1 09/16/21, 09:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16782

  5. Jochen Roth uploaded patch set 3 09/16/21, 15:05

  6. core-ci voted on patch set 3 V -1 09/16/21, 15:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16809

  7. Jochen Roth uploaded patch set 4 09/17/21, 13:06

  8. core-ci voted on patch set 4 V -1 09/17/21, 14:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16876

  9. Jochen Roth uploaded patch set 5 09/17/21, 15:12

  10. core-ci voted on patch set 5 V +1 09/17/21, 15:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16884

  11. Jochen Roth uploaded patch set 6 10/04/21, 09:10

  12. Oli Bartsch commented on patch set 6 10/04/21, 09:26

    method

    _modal.scss:154

    Where is this value from?

    _modal.scss:158

    Where is this value from?

    _modal.scss:190

    Should be handled in modal configuration

    _element_cropper.scss:1

    let's use &.cropper in the body (IMO easier to read)

    ImageManipulation.ts:183

    Could you explain this a bit? I'm just curious why we have to wait while we already use a callback.

    ImageManipulation.ts:241

    Shouldn't this happen automatically?

    ImageManipulation.ts:250

    AFAIK, this can be handled in modal configuration.

    ImageManipulation.ts:261

    Can those lines be removed then?

    ImageManipulationWizard.html:40

    Good catch!
  13. core-ci voted on patch set 6 V +1 10/04/21, 09:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17539

  14. Jochen Roth uploaded patch set 7 10/04/21, 13:13

  15. Jochen Roth commented on patch set 7 10/04/21, 13:20

    Thanks for your feedback. :-)

    Reply

    Done

    _modal.scss:154 Reply Unresolved

    This is the width of the sidebar panel.

    _modal.scss:158 Reply Unresolved

    This is the width of the sidebar panel.

    _modal.scss:190 Reply Unresolved

    This is the sidebar accordion for the cropping variants. One always needs to be open. This is hardcorded in bootstraps accordion. Therefore the pointer events have been disabled.

    _element_cropper.scss:1 Reply

    Done

    ImageManipulation.ts:183 Reply Unresolved

    Thanks, helped me to find a better position for this chunk of code. Now triggering `this.update()` within `this.init()` method to be sure the cropper is initialized correctly. It was meant to wait for `this.init()`, which was not a good idea at all.

    ImageManipulation.ts:241 Reply Unresolved

    Nope not in this case. This is basically just the "image loading spinner" for the image to be cropped and not the ajax content loading spinner. That's why i have to remove it here.

    ImageManipulation.ts:250 Reply Unresolved

    There is currently not option in Modal.ts to do so. Leaving it as is for now.

    ImageManipulation.ts:261 Reply

    Done
  1. Jochen Roth updated the commit message in patch set 8 10/04/21, 13:20

  2. core-ci voted on patch set 7 V +1 10/04/21, 13:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17556

  3. core-ci voted on patch set 8 V +1 10/04/21, 13:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17557

  4. Nikita Hovratov voted on patch set 8 V +1 10/04/21, 13:55

  5. Jochen Roth uploaded patch set 9 11/04/21, 10:09

  6. Jochen Roth uploaded patch set 10 11/04/21, 10:14

  7. core-ci voted on patch set 9 V +1 11/04/21, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18855

  8. core-ci voted on patch set 10 V +1 11/04/21, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18856

  9. Jochen Roth uploaded patch set 11 11/04/21, 12:29

  10. core-ci voted on patch set 11 V -1 11/04/21, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18877

  11. Jochen Roth rebased onto patch set 12 11/04/21, 13:51

  12. core-ci voted on patch set 12 V +1 11/04/21, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18886

  13. Anja Leichsenring updated the commit message in patch set 13 11/04/21, 14:49

  14. Anja Leichsenring voted on patch set 13 V +1 CR +1 11/04/21, 14:55

  15. core-ci voted on patch set 13 V +1 11/04/21, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18894

  16. Jochen Roth uploaded patch set 14 11/04/21, 16:56

  17. core-ci voted on patch set 14 V -1 11/04/21, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18914

  18. core-ci commented on patch set 14 11/05/21, 07:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18914

  19. Anja Leichsenring rebased onto patch set 15 11/05/21, 07:21

  20. core-ci voted on patch set 15 V -1 11/05/21, 07:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18922

  21. Jochen Roth uploaded patch set 16 11/05/21, 09:36

  22. core-ci voted on patch set 16 V +1 11/05/21, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18934

  23. Anja Leichsenring voted on patch set 16 V +1 CR +1 11/05/21, 10:03

  24. Andreas Kienast voted on patch set 16 V +2 CR +2 11/05/21, 10:11

  25. Andreas Kienast merged patch set 17 11/05/21, 10:11