71088[TASK] Add EventDispatcher to symfony console application
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Simon Gilli +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Simon Gilli +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1113
-
Benjamin Franzke uploaded patch set 1 09/14/21, 22:27
-
core-ci voted on patch set 1 V +1 09/14/21, 22:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16725
-
Benjamin Franzke commented on patch set 1 09/16/21, 20:18
This can be tested by installing an extension that tries to use symfony events, like: https://github.com/bnf/typo3-log-to-console Then add logs to an arbitrary command, e.g to SiteListCommand: \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Log\LogManager::class)->getLogger(self::class)->error('Error Test: {foo}', ['foo' => 'bar']); \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Log\LogManager::class)->getLogger(self::class)->warning('Warning Test: {foo}', ['foo' => 'bar']); \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Log\LogManager::class)->getLogger(self::class)->notice('Notice Test: {foo}', ['foo' => 'bar']); \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Log\LogManager::class)->getLogger(self::class)->info('Info Test: {foo}', ['foo' => 'bar']); \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(\TYPO3\CMS\Core\Log\LogManager::class)->getLogger(self::class)->debug('Debug Test: {foo}', ['foo' => 'bar']); then execute the following commands to see the individual logging levels to be included in stderr output: bin/typo3 site:list -q bin/typo3 site:list bin/typo3 site:list -v bin/typo3 site:list -vv bin/typo3 site:list -vvv -
Benjamin Franzke uploaded patch set 2 09/16/21, 20:20
-
Benjamin Franzke commented on patch set 2 09/16/21, 20:20
Not needed as ExecuteSchedulableCommandTask uses a NullOutput as console output. -
core-ci voted on patch set 2 V +1 09/16/21, 20:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16829
-
Benjamin Franzke wrote 09/16/21, 21:01
Topic set to cli -
Simon Gilli voted on patch set 2 V +1 CR +1 09/20/21, 15:24
-
Simon Gilli wrote 09/20/21, 15:25
Removed Verified+1 by Simon Gilli <typo3@gilbertsoft.org> -
Simon Gilli voted on patch set 2 V +1 09/22/21, 19:10
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 09/27/21, 19:26
-
Benjamin Franzke voted on patch set 2 V +2 CR +2 09/30/21, 20:27
-
Benjamin Franzke merged patch set 3 09/30/21, 20:27