71089[TASK] Deprecate extbase ViewInterface
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 18
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php3+4 −5
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+2 −2
- typo3/sysext/backend/Classes/View/BackendTemplateView.php+3 −1
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+1 −0
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/TotpProvider.php3+3 −13
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95222-ExtbaseViewInterface.rstnew+56 −0
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php3+5 −13
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+16 −17
- typo3/sysext/extbase/Classes/Mvc/View/GenericViewResolver.php+3 −0
- typo3/sysext/extbase/Classes/Mvc/View/JsonView.php+23 −1
- typo3/sysext/extbase/Classes/Mvc/View/ViewInterface.php+2 −0
- typo3/sysext/extbase/Configuration/Services.php+2 −0
- typo3/sysext/felogin/Classes/Event/AbstractConfirmedEvent.php+7 −0
- typo3/sysext/felogin/Classes/Event/ModifyLoginFormViewEvent.php+7 −0
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+4 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+0 −7
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php6+4 −16
Review log 1420
-
Christian Kuhn uploaded patch set 1 09/15/21, 12:11
-
Christian Kuhn updated the commit message in patch set 2 09/15/21, 12:13
-
core-ci voted on patch set 1 V -1 09/15/21, 12:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16737
-
core-ci voted on patch set 2 V -1 09/15/21, 12:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16738
-
Christian Kuhn uploaded patch set 3 09/15/21, 12:21
-
core-ci voted on patch set 3 V -1 09/15/21, 12:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16739
-
Christian Kuhn uploaded patch set 4 09/15/21, 12:44
-
core-ci voted on patch set 4 V +1 09/15/21, 12:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16740
-
Jochen Roth voted on patch set 4 V +1 CR +1 09/15/21, 14:36
-
Oli Bartsch commented on patch set 4 CR -1 09/15/21, 22:18
TotpProvider.php:261Using the interface here was on purpose, since it allows to easily change the actual implementation later on.DashboardController.php:54This has to be defined as nullable, since it's not initialized in constructor.ViewModuleController.php:57This has to be defined as nullable, since it's not initialized in constructor.ViewModuleController.php:95Wouldn't it make more sense to still initialize the view here (as the name suggests) and to return the object instead of manipulating a class variable? AFAICS $this->view is only used in showAction(), which is also the only method which calls intializeview(). Therefore, IMO no need for a class variable. -
Christian Kuhn commented on patch set 4 09/16/21, 09:49
MfaConfigurationController.php:38Replyi went with StandaloneView for two reasons: a) This internal controller uses StandaloneView directly, there is little point in type hinting an interface here. b) The fluid ViewInterface does not specify all methods - *maybe* a full interface should be created later, but that's a v12 task.TotpProvider.php:261Replyfluid view interface does not have setTemplate which is used below.DashboardController.php:54Replyno. it is never read before it's written. this is ok.ViewModuleController.php:57Replyimho, no.ViewModuleController.php:95Replyi suspect we'll inject a view instance later on. it's helpful to see this and having the current makeInstance() in __construct() for now, imho. -
Christian Kuhn commented on patch set 4 09/16/21, 11:45
MfaConfigurationController.php:38ReplyAckTotpProvider.php:261ReplyAckDashboardController.php:54Replyok, we'll set nullable for now and will sort this out in coredev channel later.ViewModuleController.php:57Replyok, we'll set nullable for now and will sort this out in coredev channel later.ViewModuleController.php:95ReplyAck -
Christian Kuhn uploaded patch set 5 09/16/21, 11:45
-
core-ci voted on patch set 5 V +1 09/16/21, 12:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16794
-
Christian Kuhn uploaded patch set 6 09/16/21, 12:31
-
Jochen Roth voted on patch set 6 V +1 CR +1 09/16/21, 12:39
-
Oli Bartsch voted on patch set 6 V +1 CR +1 09/16/21, 12:44
-
core-ci voted on patch set 6 V +1 09/16/21, 12:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16797
-
Christian Kuhn voted on patch set 6 V +2 CR +2 09/16/21, 12:44
-
Christian Kuhn merged patch set 7 09/16/21, 12:44
MfaConfigurationController.php:38