Review main Merged

71090[BUGFIX] Add fallback for undefined array key - versionNumberInFilename

Jochen Roth CR +2 V +2 Easy +1 −1 updated 09/16/21, 10:46

Commit message

[BE]versionNumberInFilename set to "true" triggers a
undefined key warning in PHP8.

This has been fixed by testing for a empty value
in the array key.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Jochen Roth uploaded patch set 1 09/15/21, 13:50

  2. core-ci voted on patch set 1 V +1 09/15/21, 14:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16742

  3. Oli Bartsch commented on patch set 1 09/15/21, 22:26

    Set [BE][versionNumberInFilename]=true, .htaccess is in place => filenames contain the number. However, I do not get this warning. How can this be reproduced? Any specific module?
  4. Christian Kuhn voted on patch set 1 V +1 CR +1 09/16/21, 10:45

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 09/16/21, 10:46

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 09/16/21, 10:46

  7. Christian Kuhn merged patch set 2 09/16/21, 10:46