71092[BUGFIX] Use type=search for SvgTree filter
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Jochen Roth +1
-
Verified V +2 Done
- Georg Ringer +2
- Jochen Roth +1
Issues 1
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeElement.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts+1 −7
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/PageTree/PageTreeFilterCest.php+4 −10
Review log 1114
-
Oli Bartsch uploaded patch set 1 09/15/21, 16:48
-
Wouter Wolters voted on patch set 1 CR +1 09/15/21, 17:00
-
core-ci voted on patch set 1 V -1 09/15/21, 17:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16747
-
Oli Bartsch uploaded patch set 2 09/15/21, 17:30
-
core-ci voted on patch set 2 V +1 09/15/21, 17:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16749
-
Jochen Roth commented on patch set 2 V -1 09/15/21, 18:19
Does not work in Firefox. https://caniuse.com/?search=search -
Jochen Roth wrote 09/15/21, 20:18
Removed Verified-1 by Jochen <rothjochen@gmail.com> -
Jochen Roth commented on patch set 2 V +1 CR +1 09/15/21, 20:19
Reply
Talked to Oli, we keep it as is. Hoping FF will fix/add this in near future. -
Georg Ringer voted on patch set 2 V +2 CR +2 09/16/21, 09:40
-
Oli Bartsch uploaded patch set 3 09/16/21, 09:46
-
Jochen Roth voted on patch set 3 V +1 CR +1 09/16/21, 09:47
-
Georg Ringer voted on patch set 3 V +2 CR +2 09/16/21, 09:56
-
Georg Ringer merged patch set 4 09/16/21, 09:56
-
core-ci voted on patch set 3 V +1 09/16/21, 10:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16786