Review main Merged

71092[BUGFIX] Use type=search for SvgTree filter

Oli Bartsch CR +2 V +2 Easy +10 −22 updated 09/16/21, 10:05

Commit message

The SvgTree filter previously used type=text,
which prevented the element from properly
responding to keyboard events, e.g. using
"escape" to clear the search term.

This is now fixed by using type=search. This
also allows to remove the manual "clearable"
initialization, which is the default browser
behaviour for this type.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1

Issues 1

Files 5

Review log 1114

  1. Oli Bartsch uploaded patch set 1 09/15/21, 16:48

  2. Wouter Wolters voted on patch set 1 CR +1 09/15/21, 17:00

  3. core-ci voted on patch set 1 V -1 09/15/21, 17:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16747

  4. Oli Bartsch uploaded patch set 2 09/15/21, 17:30

  5. core-ci voted on patch set 2 V +1 09/15/21, 17:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16749

  6. Jochen Roth commented on patch set 2 V -1 09/15/21, 18:19

    Does not work in Firefox. https://caniuse.com/?search=search
  7. Jochen Roth wrote 09/15/21, 20:18

    Removed Verified-1 by Jochen <rothjochen@gmail.com>
  8. Jochen Roth commented on patch set 2 V +1 CR +1 09/15/21, 20:19

    Reply

    Talked to Oli, we keep it as is. Hoping FF will fix/add this in near future.
  9. Georg Ringer voted on patch set 2 V +2 CR +2 09/16/21, 09:40

  10. Oli Bartsch uploaded patch set 3 09/16/21, 09:46

  11. Jochen Roth voted on patch set 3 V +1 CR +1 09/16/21, 09:47

  12. Georg Ringer voted on patch set 3 V +2 CR +2 09/16/21, 09:56

  13. Georg Ringer merged patch set 4 09/16/21, 09:56

  14. core-ci voted on patch set 3 V +1 09/16/21, 10:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16786