71093[TASK] Remove duplicated table information in recycler
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+35 −35
- typo3/sysext/recycler/Resources/Private/Partials/RecordsTable/DeletedRecord.html+1 −4
- typo3/sysext/recycler/Resources/Private/Templates/Ajax/RecordsTable.html+12 −8
- typo3/sysext/recycler/Resources/Private/Templates/RecyclerModule/Index.html+0 −1
Review log 1519
-
Georg Ringer uploaded patch set 1 09/15/21, 17:14
-
Georg Ringer commented on patch set 1 09/15/21, 17:16
This change is ready for review. -
core-ci voted on patch set 1 V +1 09/15/21, 17:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16748
-
Wouter Wolters voted on patch set 1 V +1 CR +1 09/15/21, 17:39
-
Riccardo De Contardi voted on patch set 1 V +1 09/15/21, 19:06
-
Oli Bartsch commented on patch set 1 CR -1 09/15/21, 21:24
It's actually not duplicated. One is the defined title from TCA ($TCA['ctrl']['title']), while the other is the actual table name. IMO this information might be important especially for admins. Therefore, I suggest to just change the corresponding title from "Record type" to "Table name" and to not remove this information completely. -
Georg Ringer uploaded patch set 2 09/16/21, 09:34
-
core-ci voted on patch set 2 V +1 09/16/21, 09:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16784
-
Jochen Roth voted on patch set 2 V +1 CR +1 09/16/21, 13:19
-
Jochen Roth rebased onto patch set 3 09/16/21, 14:36
-
Jochen Roth commented on patch set 3 V +1 CR +1 09/16/21, 14:38
Sorry, did not intend to change anything here. But should not do any harm. -
core-ci voted on patch set 3 V +1 09/16/21, 14:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16806
-
Oli Bartsch uploaded patch set 4 09/16/21, 17:06
-
Oli Bartsch voted on patch set 4 V +1 CR +1 09/16/21, 17:06
-
Rachel Foucard voted on patch set 3 V +1 CR +1 09/16/21, 17:10
-
core-ci voted on patch set 4 V +1 09/16/21, 17:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16822
-
Jochen Roth voted on patch set 4 V +1 CR +1 09/16/21, 17:28
-
Georg Ringer voted on patch set 4 V +2 CR +2 09/16/21, 18:30
-
Georg Ringer merged patch set 5 09/16/21, 18:30