Review main Merged

71093[TASK] Remove duplicated table information in recycler

Georg Ringer CR +2 V +2 Normal +48 −48 updated 09/16/21, 18:30

Commit message

The record information element displayed the records'
table name as "record type", while the actual record
row already contains a "record type" column, displaying
the TCA defined title for the table.

This is now streamlined. The "record type" column is
removed from both, the actual row and the information
element. All records are now grouped by their record
type. The grouping is visualized by a dedicated "header"
row, showing the TCA defined title and if debug enabled
and admin user, also the table name in brackets (as
known from FormEngine).

In case the listing is filtered by record type, the
additional "header" row is not displayed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1519

  1. Georg Ringer uploaded patch set 1 09/15/21, 17:14

  2. Georg Ringer commented on patch set 1 09/15/21, 17:16

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/15/21, 17:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16748

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 09/15/21, 17:39

  5. Riccardo De Contardi voted on patch set 1 V +1 09/15/21, 19:06

  6. Oli Bartsch commented on patch set 1 CR -1 09/15/21, 21:24

    It's actually not duplicated. One is the defined title from TCA ($TCA['ctrl']['title']), while the other is the actual table name. IMO this information might be important especially for admins. Therefore, I suggest to just change the corresponding title from "Record type" to "Table name" and to not remove this information completely.
  7. Georg Ringer uploaded patch set 2 09/16/21, 09:34

  8. core-ci voted on patch set 2 V +1 09/16/21, 09:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16784

  9. Jochen Roth voted on patch set 2 V +1 CR +1 09/16/21, 13:19

  10. Jochen Roth rebased onto patch set 3 09/16/21, 14:36

  11. Jochen Roth commented on patch set 3 V +1 CR +1 09/16/21, 14:38

    Sorry, did not intend to change anything here. But should not do any harm.
  12. core-ci voted on patch set 3 V +1 09/16/21, 14:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16806

  13. Oli Bartsch uploaded patch set 4 09/16/21, 17:06

  14. Oli Bartsch voted on patch set 4 V +1 CR +1 09/16/21, 17:06

  15. Rachel Foucard voted on patch set 3 V +1 CR +1 09/16/21, 17:10

  16. core-ci voted on patch set 4 V +1 09/16/21, 17:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16822

  17. Jochen Roth voted on patch set 4 V +1 CR +1 09/16/21, 17:28

  18. Georg Ringer voted on patch set 4 V +2 CR +2 09/16/21, 18:30

  19. Georg Ringer merged patch set 5 09/16/21, 18:30