71095[BUGFIX] Fix path to SystemEmail layout in EXT:workspaces
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 78
-
Wouter Wolters uploaded patch set 1 09/15/21, 18:11
-
core-ci voted on patch set 1 V +1 09/15/21, 18:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16755
-
Christian Kuhn voted on patch set 1 CR +1 09/15/21, 19:01
-
Oli Bartsch commented on patch set 1 CR -1 09/15/21, 21:32
This is IMO wrong. The settings just extend the already existing MAIL configuration from $GLOBALS['TYPO3_CONF_VARS']['MAIL']). This makes it possible to override those Layouts/Templates (https://github.com/TYPO3/typo3/blob/master/typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php#L164). This is the usual workflow for fluid templates and should not be touched. It actually seems like the reported messed up the $GLOBALS['TYPO3_CONF_VARS']['MAIL'] configuration by removing the defaults, set in the DefaultConfiguration.php (https://github.com/TYPO3/typo3/blob/master/typo3/sysext/core/Configuration/DefaultConfiguration.php#L1467). With a fresh v11, I can't reproduce this bug. -
Wouter Wolters commented on patch set 1 09/15/21, 22:50
Reply
sorry but the defaults are IMO wrong here and this patch is correct, -
Oli Bartsch commented on patch set 1 09/15/21, 23:15
Reply
What's wrong with the defaults? That's exactly where the Core files are located. This was actually the idea when fluid emails were introduced. All emails have a consistent look, since they all rely on the default core template (which can of course be extended/overriden by adding additional paths to the $GLOBAL config). The fact that EXT:workspaces adds additional TSconfig options on top is just an additional layer. This config is then just merged with the $GLOBALS config. Therefore, as said, the reporter must have removed the defaults from the $GLOBALS config, while not adding own paths. -
Christian Kuhn voted on patch set 1 CR 0 09/16/21, 08:34
-
Wouter Wolters abandoned the change 09/16/21, 08:47