Review main Merged

71096[TASK] Drop obsolete todos from MM table generator

Christian Kuhn CR +2 V +2 Easy +0 −9 updated 09/15/21, 21:21

Commit message

Database columns 'sorting' and 'sorting_foreign' for
MM relation tables are hard coded and not a valid TCA
configuration option since a long time. Drop two
recently added todo's to clearify this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 09/15/21, 19:24

  2. Christian Kuhn uploaded patch set 2 09/15/21, 19:27

  3. Björn Jacob voted on patch set 2 V +1 CR +1 09/15/21, 19:34

  4. core-ci voted on patch set 1 V +1 09/15/21, 19:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16760

  5. core-ci voted on patch set 2 V +1 09/15/21, 19:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16761

  6. Christian Kuhn commented on patch set 2 09/15/21, 20:21

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 09/15/21, 21:16

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 09/15/21, 21:21

  9. Christian Kuhn merged patch set 3 09/15/21, 21:21